Skip to content

Conversation

nahumtimerman
Copy link
Collaborator

reservation output writer should be able to handle bytes and not just string

@nahumtimerman nahumtimerman requested a review from AdamSharon May 3, 2021 07:20
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 87.547% when pulling 9b319af on bug/output_to_reservation_fails into 7beb63f on develop.

@AdamSharon
Copy link

does this change need to be in the warning section as well ? since it write a message to output here too.

def write_warning(self, msg): self.session.WriteMessageToReservationOutput(self.resevation_id, '<font color="#f48342">WARNING: %s</font>'%msg)

@nahumtimerman nahumtimerman merged commit 2a18525 into develop May 3, 2021
@nahumtimerman nahumtimerman deleted the bug/output_to_reservation_fails branch May 3, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants