Skip to content

initial #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2021
Merged

initial #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package/cloudshell/cm/customscript/domain/reservation_output_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ def write_warning(self, msg):

def _remove_illegal_chars(self, str):
rx = re.compile('\x00')
str = str if not getattr(str, "decode", False) else str.decode() # can be a bytes-like object
return rx.sub('', str)
8 changes: 8 additions & 0 deletions package/tests/test_reservation_output_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,11 @@ def test_write(self):
writer = ReservationOutputWriter(session, context)
writer.write('some msg')
session.WriteMessageToReservationOutput.assert_called_once_with('1234','some msg')

def test_write_with_bytes(self):
session = Mock()
context = Mock()
context.reservation.reservation_id = '1234'
writer = ReservationOutputWriter(session, context)
writer.write(b'some msg')
session.WriteMessageToReservationOutput.assert_called_once_with('1234','some msg')