Skip to content

Conversation

gabhijit-izel
Copy link
Contributor

@gabhijit-izel gabhijit-izel commented Feb 23, 2017

  • A much simpler and robust algorithm for subnet allocation
  • Quick testing with multiple create/delete subnets

Description

A few sentences describing the overall goals of the pull request's commits.

Breaking

NO


This change is Reviewable

 - A much simpler and robust algorithm for subnet allocation
 - Quick testing with multiple create/delete subnets
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 94.588% when pulling aa9f5df on feature/gabhijit-izel_75_subnet_cidr_fix into f5eef9b on develop.

@alexazarh
Copy link
Contributor

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


package/cloudshell/cp/openstack/domain/services/neutron/neutron_network_service.py, line 6 at r1 (raw file):

import ipaddress
do we need to update the requirements file?


Comments from Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 95.101% when pulling 304a3f1 on feature/gabhijit-izel_75_subnet_cidr_fix into f5eef9b on develop.

@alexazarh
Copy link
Contributor

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@alexazarh alexazarh merged commit 3497bfe into develop Feb 23, 2017
@alexazarh alexazarh deleted the feature/gabhijit-izel_75_subnet_cidr_fix branch February 23, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants