Skip to content

Conversation

HengchengZhang
Copy link
Member

Closes #691

Removed the following broken links

References
----------
.. [1] Wealth distribution and social mobility in the US:
A quantitative approach (Benhabib, Bisin, Luo, 2017).
https://www.econ.nyu.edu/user/bisina/RevisionAugust.pdf

References
----------
https://lectures.quantecon.org/py/kalman.html

References
----------
https://lectures.quantecon.org/py/kalman.html

:: See
:: http://docs.continuum.io/conda/build.html
:: for a list of environment variables that are set during the build process.

References
----------
https://lectures.quantecon.org/py/stationary_densities.html

# See
# http://docs.continuum.io/conda/build.html for
# more information about meta.yaml

@oyamad
Copy link
Member

oyamad commented Apr 9, 2023

@HengchengZhang Thank you for the PR!

  • I think the links to lectures should be updated to new ones, rather than to remove.
  • Benhabib, Bisin, Luo, 2017 seems to have been published in AER. Can anyone confirm?
  • @mmcky What are the files bld.bat, build.sh and meta.yaml for?

@shlff
Copy link
Member

shlff commented Apr 16, 2023

@HengchengZhang Thank you for the PR!

  • I think the links to lectures should be updated to new ones, rather than to remove.
  • Benhabib, Bisin, Luo, 2017 seems to have been published in AER. Can anyone confirm?
  • @mmcky What are the files bld.bat, build.sh and meta.yaml for?

Thanks @oyamad and @HengchengZhang . I can confirm the publication of Benhabib, Bisin, and Luo in AER:

@HengchengZhang
Copy link
Member Author

Thanks for your advice and confirmation @oyamad and @shlff.

I've updated the correct links to the files.

I think this domain is no longer being used

summary: 'Code for quant-econ.net'

Shall we change it to quantecon.org?

@mmcky
Copy link
Contributor

mmcky commented Apr 27, 2023

thanks @HengchengZhang

Shall we change it to quantecon.org?

Yes please.

@mmcky
Copy link
Contributor

mmcky commented Apr 27, 2023

@mmcky What are the files bld.bat, build.sh and meta.yaml for?

I think we can remove these.

They were initially there to support conda-forge releases but that infrastructure is probably old and quantecon has been making its way into default anaconda channels.

https://repo.anaconda.com/pkgs/main/linux-64/

Although I don't see 0.6.0 which is surprising given it's been out since December 2022

@coveralls
Copy link

coveralls commented Apr 27, 2023

Coverage Status

Coverage: 92.988%. Remained the same when pulling e350e57 on HengchengZhang:fix-issue-#691 into 67fe704 on QuantEcon:main.

@HengchengZhang
Copy link
Member Author

thanks @HengchengZhang

Shall we change it to quantecon.org?

Yes please.

Thanks @mmcky, updated.

Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for updating the links to the new links @HengchengZhang. Thanks @oyamad for the review.

@HengchengZhang
Copy link
Member Author

Many thanks for your review @oyamad, I've applied the changes.

@mmcky mmcky merged commit 1c0c214 into QuantEcon:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Update or remove broken links to QE lectures
5 participants