-
-
Notifications
You must be signed in to change notification settings - Fork 54
Fix inconsistent quotation mark usage across lecture files #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hi @mmcky , I quickly checked with the lectures, and all the points mentioned above is correct. in some lectures, the style The difference between I checked it with the lectures pointed out by copilot, and there does exist such inconsistency. |
Co-authored-by: mmcky <8263752+mmcky@users.noreply.github.com>
thanks @bishmaybarik -- let's check the |
@jit | ||
def simulate(a, b, T=50, N=500): | ||
''' | ||
"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change here might be a problem. Should we let it stay as '''
instead of "'
? @mmcky what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right! I incorrectly changed the Python docstring '''
to "'
which broke the code syntax. Thank you for catching and fixing this in commit e87cdc9. The triple quotes should indeed stay as '''
for proper Python docstring formatting.
``` | ||
|
||
```{code-cell} ipython3 | ||
`"{code-cell} ipython3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even this change is incorrect. We should let it stay as (```)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct again! I mistakenly changed the code block delimiter from to quotes, which broke the MyST markdown syntax. Thank you for fixing this in commit e87cdc9. Code blocks should definitely remain as
for proper rendering.
📖 Netlify Preview Ready! Preview URL: https://pr-641--sunny-cactus-210e3e.netlify.app (ebf1770) 📚 Changed Lecture Pages: ak2, ar1_turningpts, exchangeable, likelihood_ratio_process, likelihood_ratio_process_2 |
1 similar comment
📖 Netlify Preview Ready! Preview URL: https://pr-641--sunny-cactus-210e3e.netlify.app (ebf1770) 📚 Changed Lecture Pages: ak2, ar1_turningpts, exchangeable, likelihood_ratio_process, likelihood_ratio_process_2 |
I think the issues I have pointed out earlier is right:
After the ![]() @mmcky I think we need to undo only this change |
📖 Netlify Preview Ready! Preview URL: https://pr-641--sunny-cactus-210e3e.netlify.app (e87cdc9) 📚 Changed Lecture Pages: ak2, ar1_turningpts, exchangeable, likelihood_ratio_process, likelihood_ratio_process_2 |
this now works as expected: ![]() @mmcky this looks ready to be merged. everything else looks fine to me. |
thanks @bishmaybarik -- indeed that would be a problem. Thanks for fixing it. |
@copilot -- @bishmaybarik has fixed some issues that were found in this PR. Can you please review and make sure you don't substitute any `` that are part of a directive (denoted by ```). An example directive is:
|
Thank you for the feedback! You're absolutely right - I should not have changed any backticks that are part of directives like ```{code-cell}. @bishmaybarik has already fixed the issues in commit e87cdc9, restoring the correct syntax for code blocks and Python docstrings. I'll be more careful to distinguish between quotation marks in regular text versus code syntax markers in the future. |
thanks @bishmaybarik |
This PR addresses inconsistent quotation mark usage throughout the lecture files where double backticks with double quotes (``text'') were used instead of proper quotation marks ("text").
Problem
Several lecture files contained inconsistent quotation formatting that appeared as improper typographic quotes in the rendered output. For example:
The text showed ``it is thrown into the ocean'' instead of the proper "it is thrown into the ocean".
Changes Made
Fixed quotation mark inconsistencies in 5 lecture files:
Validation
This ensures consistent and proper quotation mark formatting throughout the lecture materials.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://storage.googleapis.com/chrome-for-testing-public/135.0.7011.0/linux64/chrome-linux64.zip
/usr/share/miniconda/envs/quantecon/bin/python -Xfrozen_modules=off -m ipykernel_launcher -f /tmp/tmp7_5e_r0y.json --HistoryManager.hist_file=:memory:
(http block)intro.quantecon.org
/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures --path-output ./ -W --keep-going --builder html
(dns block)jax.quantecon.org
/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures --path-output ./ -W --keep-going --builder html
(dns block)python-advanced.quantecon.org
/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures --path-output ./ -W --keep-going --builder html
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.