Skip to content

Conversation

PiTheGuy
Copy link
Contributor

Changing stat icon settings via the menu bar would trigger a stat reload on the main GUI thread, which would cause the application to hang while stats were reloading. This PR changes the stat reload to run asynchronously

@ix0rai ix0rai added bug Something isn't working user interface affects the enigma ui labels Sep 18, 2025
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use SwingUtilities::invokeLater instead of manually creating threads?

@supersaiyansubtlety
Copy link
Member

My bad, it needs to be made async in addition to using invokeLater for the event queue (I was thinking that already made it async).
I made a PR doing both: PiTheGuy#1

Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ix0rai ix0rai merged commit d7510b4 into QuiltMC:develop/2.7 Oct 4, 2025
2 checks passed
@PiTheGuy PiTheGuy deleted the stat-menu-performance branch October 4, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user interface affects the enigma ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants