Skip to content

Fix stat menu performance issue #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 4, 2025
Merged

Fix stat menu performance issue #302

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97519f4
Update StatsMenu.java
PiTheGuy Sep 18, 2025
bd4b1b4
Use SwingUtilities.invokeLater
PiTheGuy Sep 18, 2025
dba728b
use runAsync in invokeLater in StatsMenu
supersaiyansubtlety Sep 19, 2025
783865d
checkstyle
supersaiyansubtlety Sep 19, 2025
e971b0f
extract method
supersaiyansubtlety Sep 19, 2025
82ad47a
Merge pull request #1 from supersaiyansubtlety/invokeAsyncLater
PiTheGuy Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions enigma-swing/src/main/java/org/quiltmc/enigma/gui/element/menu_bar/view/StatsMenu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@

import javax.swing.JCheckBoxMenuItem;
import javax.swing.JMenu;
import javax.swing.SwingUtilities;
import java.util.HashMap;
import java.util.Map;

import static java.util.concurrent.CompletableFuture.runAsync;

public class StatsMenu extends AbstractEnigmaMenu {
private final JCheckBoxMenuItem enableIcons = new JCheckBoxMenuItem();
private final JCheckBoxMenuItem includeSynthetic = new JCheckBoxMenuItem();
Expand Down Expand Up @@ -67,17 +70,17 @@ public void updateState(boolean jarOpen, ConnectionState state) {

private void onEnableIconsClicked() {
Config.main().features.enableClassTreeStatIcons.setValue(this.enableIcons.isSelected());
this.gui.getController().regenerateAndUpdateStatIcons();
this.updateIconsLater();
}

private void onIncludeSyntheticClicked() {
Config.main().stats.shouldIncludeSyntheticParameters.setValue(this.includeSynthetic.isSelected());
this.gui.getController().regenerateAndUpdateStatIcons();
this.updateIconsLater();
}

private void onCountFallbackClicked() {
Config.main().stats.shouldCountFallbackNames.setValue(this.countFallback.isSelected());
this.gui.getController().regenerateAndUpdateStatIcons();
this.updateIconsLater();
}

private void onCheckboxClicked(StatType type) {
Expand All @@ -89,6 +92,10 @@ private void onCheckboxClicked(StatType type) {
Config.stats().includedStatTypes.value().remove(type);
}

this.gui.getController().regenerateAndUpdateStatIcons();
this.updateIconsLater();
}

private void updateIconsLater() {
SwingUtilities.invokeLater(() -> runAsync(() -> this.gui.getController().regenerateAndUpdateStatIcons()));
}
}