Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added static site adapter #4461

Merged
merged 6 commits into from
Oct 11, 2023
Merged

docs: added static site adapter #4461

merged 6 commits into from
Oct 11, 2023

Conversation

the-r3aper7
Copy link
Contributor

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Jun 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@the-r3aper7
Copy link
Contributor Author

the-r3aper7 commented Jun 11, 2023 •
edited
Loading

@manucorporat @adamdbradley i was testing for static site and found that we cannot use useSignal, useStore and useRouteAction however, useTask is working just fine, so should i mention which API we can use with adapter?

@zanettin zanettin added the COMP: docs Improvements or additions to documentation label Jun 11, 2023
@zanettin zanettin added the WAITING FOR: user Further information is requested from the issue / pr opener label Aug 2, 2023
@gioboa
Copy link
Member

gioboa commented Oct 10, 2023

@the-r3aper7 thanks for your help. are you still on this PR? which part is missing?

@the-r3aper7
Copy link
Contributor Author

the-r3aper7 commented Oct 10, 2023 •
edited
Loading

yes last time i check some APIs were not working at build time.
I have asked about it but no reply have come.

@gioboa
Copy link
Member

gioboa commented Oct 10, 2023

🤔 the SSG integration is working well. server APIs can't work because there is no active server.

@the-r3aper7
Copy link
Contributor Author

🤔 the SSG integration is working well. server APIs can't work because there is no active server.

so, useStore and useSignal is part of server or client and how can a user a say simple counter app?

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0e6dcec

@the-r3aper7 the-r3aper7 marked this pull request as ready for review October 11, 2023 13:44
gioboa
gioboa approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me. thanks

@gioboa gioboa enabled auto-merge (squash) October 11, 2023 13:54
@gioboa gioboa disabled auto-merge October 11, 2023 13:54
@gioboa
Copy link
Member

gioboa commented Oct 11, 2023

🤔 the SSG integration is working well. server APIs can't work because there is no active server.

so, useStore and useSignal is part of server or client and how can a user a say simple counter app?

useStore and useSignal are working fine with SSG

@the-r3aper7
Copy link
Contributor Author

🤔 the SSG integration is working well. server APIs can't work because there is no active server.

so, useStore and useSignal is part of server or client and how can a user a say simple counter app?

useStore and useSignal are working fine with SSG

it was not working 4 months ago 😅

@gioboa gioboa merged commit b3cdc4e into QwikDev:main Oct 11, 2023
20 checks passed
@the-r3aper7 the-r3aper7 deleted the static-site-adapter-docs branch October 11, 2023 15:11
kodiakhq bot referenced this pull request in ascorbic/unpic-img Oct 22, 2023
@renovate
chore(deps): update dependency @builder.io/qwik to v1.2.14 (#346)
c05deb1 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.13` -> `1.2.14`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.13/1.2.14) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.2.13/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.2.13/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.2.14`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.14)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.13...v1.2.14)

##### What's Changed

-   refactor(e2e): Make tests more robust by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5279](https://togithub.com/BuilderIO/qwik/pull/5279)
-   fix(core): dynamic text signals by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5284](https://togithub.com/BuilderIO/qwik/pull/5284)
-   fix(qwik-city): ensure `server$` has correct `this` on server-side by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5278](https://togithub.com/BuilderIO/qwik/pull/5278)
-   docs(localization): auto-translation by [@&#8203;tzdesign](https://togithub.com/tzdesign) in [https://github.com/BuilderIO/qwik/pull/5287](https://togithub.com/BuilderIO/qwik/pull/5287)
-   fix: grammatical issue with Basic Projection Tutorial by [@&#8203;harishkrishnan24](https://togithub.com/harishkrishnan24) in [https://github.com/BuilderIO/qwik/pull/5286](https://togithub.com/BuilderIO/qwik/pull/5286)
-   docs: add note that Slots don't work without `component$()` by [@&#8203;jakovljevic-mladen](https://togithub.com/jakovljevic-mladen) in [https://github.com/BuilderIO/qwik/pull/5290](https://togithub.com/BuilderIO/qwik/pull/5290)
-   docs: Update pages.json to include QuoteMingle by [@&#8203;Decimalpointe](https://togithub.com/Decimalpointe) in [https://github.com/BuilderIO/qwik/pull/5285](https://togithub.com/BuilderIO/qwik/pull/5285)
-   docs(cookbook): Add dark theme description by [@&#8203;Inaam-Ur-Rehman](https://togithub.com/Inaam-Ur-Rehman) in [https://github.com/BuilderIO/qwik/pull/5255](https://togithub.com/BuilderIO/qwik/pull/5255)
-   chore: Prettier jsdoc by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5293](https://togithub.com/BuilderIO/qwik/pull/5293)
-   docs: fix broken link by [@&#8203;Craiqser](https://togithub.com/Craiqser) in [https://github.com/BuilderIO/qwik/pull/5294](https://togithub.com/BuilderIO/qwik/pull/5294)
-   docs: fix contributor name by [@&#8203;gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5296](https://togithub.com/BuilderIO/qwik/pull/5296)
-   docs: fix fastify link by [@&#8203;Craiqser](https://togithub.com/Craiqser) in [https://github.com/BuilderIO/qwik/pull/5298](https://togithub.com/BuilderIO/qwik/pull/5298)
-   chore: docs.sync + update pnpm by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5299](https://togithub.com/BuilderIO/qwik/pull/5299)
-   docs: added static site adapter by [@&#8203;the-r3aper7](https://togithub.com/the-r3aper7) in [https://github.com/BuilderIO/qwik/pull/4461](https://togithub.com/BuilderIO/qwik/pull/4461)
-   docs: Switch to using insights for generating bundles by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5302](https://togithub.com/BuilderIO/qwik/pull/5302)
-   fix: Add a missing CSS import to Storybook by [@&#8203;bebraw](https://togithub.com/bebraw) in [https://github.com/BuilderIO/qwik/pull/5308](https://togithub.com/BuilderIO/qwik/pull/5308)
-   docs: Add a missing link to qrl docs by [@&#8203;bebraw](https://togithub.com/bebraw) in [https://github.com/BuilderIO/qwik/pull/5307](https://togithub.com/BuilderIO/qwik/pull/5307)
-   chore: switch to vitest by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5300](https://togithub.com/BuilderIO/qwik/pull/5300)
-   fix(core): fix pause logic failing to capture component by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5309](https://togithub.com/BuilderIO/qwik/pull/5309)
-   chore: rollback drizzle to 0.28.3 by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5310](https://togithub.com/BuilderIO/qwik/pull/5310)
-   fix(core): prevent SSR rendering on images by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5313](https://togithub.com/BuilderIO/qwik/pull/5313)
-   docs: add qwik-morocco community image  by [@&#8203;ayoub9494](https://togithub.com/ayoub9494) in [https://github.com/BuilderIO/qwik/pull/5317](https://togithub.com/BuilderIO/qwik/pull/5317)
-   docs: add moroccan meetup group by [@&#8203;ayoub9494](https://togithub.com/ayoub9494) in [https://github.com/BuilderIO/qwik/pull/5314](https://togithub.com/BuilderIO/qwik/pull/5314)
-   docs: update authjs by [@&#8203;ayoub9494](https://togithub.com/ayoub9494) in [https://github.com/BuilderIO/qwik/pull/5316](https://togithub.com/BuilderIO/qwik/pull/5316)
-   fix(comment): Updated firebase entry comments to reference Firebase correctly by [@&#8203;vdemcak](https://togithub.com/vdemcak) in [https://github.com/BuilderIO/qwik/pull/5318](https://togithub.com/BuilderIO/qwik/pull/5318)
-   docs: fix component types in examples by [@&#8203;abstractalgo](https://togithub.com/abstractalgo) in [https://github.com/BuilderIO/qwik/pull/5319](https://togithub.com/BuilderIO/qwik/pull/5319)
-   feat(qwik-core): expose isSignal helper function by [@&#8203;octoper](https://togithub.com/octoper) in [https://github.com/BuilderIO/qwik/pull/4749](https://togithub.com/BuilderIO/qwik/pull/4749)
-   docs: fix syntax error in mdx tags example by [@&#8203;ihaback](https://togithub.com/ihaback) in [https://github.com/BuilderIO/qwik/pull/5324](https://togithub.com/BuilderIO/qwik/pull/5324)
-   fix: docs Cloudflare build by [@&#8203;gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5329](https://togithub.com/BuilderIO/qwik/pull/5329)
-   fix: Bump pandacss version to a Qwik compatible one by [@&#8203;NiklasPor](https://togithub.com/NiklasPor) in [https://github.com/BuilderIO/qwik/pull/5330](https://togithub.com/BuilderIO/qwik/pull/5330)
-   chore: upgrade supabase version to 2.38.1 by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5331](https://togithub.com/BuilderIO/qwik/pull/5331)
-   refactor(core): No $slotParent$ by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5263](https://togithub.com/BuilderIO/qwik/pull/5263)
-   fix: [@&#8203;builder](https://togithub.com/builder).io/qwik/build should not SSR render by [@&#8203;mpeg](https://togithub.com/mpeg) in [https://github.com/BuilderIO/qwik/pull/5326](https://togithub.com/BuilderIO/qwik/pull/5326)
-   chore: 1.2.14 by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5332](https://togithub.com/BuilderIO/qwik/pull/5332)

##### New Contributors

-   [@&#8203;Decimalpointe](https://togithub.com/Decimalpointe) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5285](https://togithub.com/BuilderIO/qwik/pull/5285)
-   [@&#8203;Inaam-Ur-Rehman](https://togithub.com/Inaam-Ur-Rehman) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5255](https://togithub.com/BuilderIO/qwik/pull/5255)
-   [@&#8203;bebraw](https://togithub.com/bebraw) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5308](https://togithub.com/BuilderIO/qwik/pull/5308)
-   [@&#8203;ayoub9494](https://togithub.com/ayoub9494) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5317](https://togithub.com/BuilderIO/qwik/pull/5317)
-   [@&#8203;vdemcak](https://togithub.com/vdemcak) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5318](https://togithub.com/BuilderIO/qwik/pull/5318)
-   [@&#8203;abstractalgo](https://togithub.com/abstractalgo) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5319](https://togithub.com/BuilderIO/qwik/pull/5319)
-   [@&#8203;ihaback](https://togithub.com/ihaback) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5324](https://togithub.com/BuilderIO/qwik/pull/5324)
-   [@&#8203;NiklasPor](https://togithub.com/NiklasPor) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5330](https://togithub.com/BuilderIO/qwik/pull/5330)
-   [@&#8203;mpeg](https://togithub.com/mpeg) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5326](https://togithub.com/BuilderIO/qwik/pull/5326)

**Full Changelog**: QwikDev/qwik@v1.2.13...v1.2.14

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

@adamdbradley adamdbradley Awaiting requested review from adamdbradley

Assignees
No one assigned
Labels
COMP: docs Improvements or additions to documentation WAITING FOR: user Further information is requested from the issue / pr opener
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-r3aper7 @gioboa @zanettin