Skip to content

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented May 10, 2022

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

This PR adds a starter to support Netlify Edge Functions.

This PR includes a vite.config.js which adds the Netlify Vite plugin. This generates an edge functions manifest and sets the output format to ES modules.

I am opening this as a draft for discussion.

Use cases and why

To test this, install the Netlify CLI globally (npm i -g netlify-cli), then run ntl build --offline and ntl dev --offline to test the site.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@ascorbic ascorbic force-pushed the mk/netlify-starter branch 2 times, most recently from e7671d4 to fd2faf8 Compare May 17, 2022 09:09
@ascorbic ascorbic marked this pull request as ready for review May 17, 2022 10:05
@ascorbic ascorbic force-pushed the mk/netlify-starter branch from bc3c1ac to 26515c3 Compare May 17, 2022 17:23
@ascorbic ascorbic force-pushed the mk/netlify-starter branch from 5899bc4 to 0fc4986 Compare May 18, 2022 07:07
Copy link
Contributor

@KyleBlankRollins KyleBlankRollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascorbic, I have some suggested edits, mostly minor. Thanks for putting this together! Looks great. 😄

@adamdbradley adamdbradley merged commit c50c27a into QwikDev:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants