fix(qwik-city): cleanup matchRouteRequest

[gioboa]

Overview

Polish matchRouteRequest method and fix typo in a comment.

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code

[netlify]

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	ff3597e

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[mhevery]

I am not convinced that this is the same behavior.
I think the old one checked it twite as it checked the URLs both with and without the trailing slash. The new one does one or the other.

[gioboa]

You are right, if the behavior is to check with or without then this code is not correct. Anyway trailingSlash is a global vite option, do we need to check both cases?

---- UPDATE ----

🤔 with trailingSlash:

• false we are checking with or without / like the first for loop in the prev implementation
• true we are always adding the final /, in the prev implementation with trailingSlash=true and pathname without / the first loop could match the route

[mhevery]

I would leave the original behavior. The cost of checking the URLs is not that much.

[gioboa]

With this code I removed one for loop and the behaviour remains the same