fix(qwik-city): do not write into a destroyed stream

[tuurbo]

Overview

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos

Description

Check if the response is already destroyed similar to checking if the response is closed.

PR #5074 fixed some of the Error [ERR_STREAM_DESTROYED]: Cannot call write after a stream was destroyed errors but sometimes closed is undefined and destroyed is true.

If checking for destroyed, I don't know if that makes checking for closed redundant so I kept the closed check.

Use cases and why

• 1. One use case
• 2. Another use case

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[netlify]

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	8f27848

[tuurbo]

Not sure if this PR fix is enough. I've been testing this PR in production and now I'm seeing error

Error: write EPIPE
    at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:94:16)
    at WriteWrap.callbackTrampoline (node:internal/async_hooks:130:17) {
  errno: -32,
  code: 'EPIPE',
  syscall: 'write'
}

I'm also logging addition info about the errors with

res.write(chunk, (error) => {
  if (error) {
    console.log({
      status,
      closed: res.closed,
      destroyed: res.destroyed,
      errored: res.errored,
      url: req.url,
      method: req.method,
      reqheaders: req.headers,
      resheaders: res?.getHeaders(),
    });
    console.error(error);
  }
});

Here is an example log

{
  status: 200,
  closed: undefined,
  destroyed: false,
  errored: undefined,
  url: '/search?term=redacted',
  method: 'GET',
  reqheaders: {...},
  resheaders: {...}
}