Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix routing page - add missing attributes. #5188

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

hamatoyogi
Copy link
Contributor

@hamatoyogi hamatoyogi commented Sep 18, 2023

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@netlify
Copy link

netlify bot commented Sep 18, 2023

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9de970c

@mhevery mhevery merged commit 2567fa1 into QwikDev:main Sep 18, 2023
21 checks passed
kodiakhq bot referenced this pull request in ascorbic/unpic-img Sep 24, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.11` -> `1.2.12`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.11/1.2.12) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.2.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.2.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.2.11/1.2.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.2.11/1.2.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.2.12`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.12)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.11...v1.2.12)

##### What's Changed

-   docs: interactive resumability Demo component to place on homepage by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/4990](https://togithub.com/BuilderIO/qwik/pull/4990)
-   Insights by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5146](https://togithub.com/BuilderIO/qwik/pull/5146)
-   docs: add routeAction$ caveat by [@&#8203;gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5147](https://togithub.com/BuilderIO/qwik/pull/5147)
-   fix(insight): Limit the size of data retrieved from the database by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5149](https://togithub.com/BuilderIO/qwik/pull/5149)
-   fix(insight): Limit the size of data retrieved from the database by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5151](https://togithub.com/BuilderIO/qwik/pull/5151)
-   chore(github-action): added semantic pr title check by [@&#8203;zanettin](https://togithub.com/zanettin) in [https://github.com/BuilderIO/qwik/pull/5152](https://togithub.com/BuilderIO/qwik/pull/5152)
-   fix(github-action): do not validate draft PRs by [@&#8203;zanettin](https://togithub.com/zanettin) in [https://github.com/BuilderIO/qwik/pull/5153](https://togithub.com/BuilderIO/qwik/pull/5153)
-   fix(github-action): do not validate draft PRs - revert by [@&#8203;zanettin](https://togithub.com/zanettin) in [https://github.com/BuilderIO/qwik/pull/5155](https://togithub.com/BuilderIO/qwik/pull/5155)
-   docs: Add expobeds.com to the showcase by [@&#8203;ilianiv](https://togithub.com/ilianiv) in [https://github.com/BuilderIO/qwik/pull/5159](https://togithub.com/BuilderIO/qwik/pull/5159)
-   chore: Update 🐼 PandaCSS integration dev dependency by [@&#8203;mrhoodz](https://togithub.com/mrhoodz) in [https://github.com/BuilderIO/qwik/pull/5156](https://togithub.com/BuilderIO/qwik/pull/5156)
-   feat: leaflet map integration adapter by [@&#8203;anartzdev](https://togithub.com/anartzdev) in [https://github.com/BuilderIO/qwik/pull/5158](https://togithub.com/BuilderIO/qwik/pull/5158)
-   fix: Ignore blob URL on getting image info by [@&#8203;genki](https://togithub.com/genki) in [https://github.com/BuilderIO/qwik/pull/5150](https://togithub.com/BuilderIO/qwik/pull/5150)
-   docs(qwik-city): correct the links to endpoints page by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [https://github.com/BuilderIO/qwik/pull/5167](https://togithub.com/BuilderIO/qwik/pull/5167)
-   docs(qwik-city): add validators by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [https://github.com/BuilderIO/qwik/pull/5166](https://togithub.com/BuilderIO/qwik/pull/5166)
-   fix: Bun install by [@&#8203;EamonHeffernan](https://togithub.com/EamonHeffernan) in [https://github.com/BuilderIO/qwik/pull/5165](https://togithub.com/BuilderIO/qwik/pull/5165)
-   docs(qwik): Fixed Link by [@&#8203;pipisso](https://togithub.com/pipisso) in [https://github.com/BuilderIO/qwik/pull/5169](https://togithub.com/BuilderIO/qwik/pull/5169)
-   fix(qwik-city): Fix rewrite home route by [@&#8203;claudioshiver](https://togithub.com/claudioshiver) in [https://github.com/BuilderIO/qwik/pull/5168](https://togithub.com/BuilderIO/qwik/pull/5168)
-   docs: use import .css?inline instead of .css by [@&#8203;sapphi-red](https://togithub.com/sapphi-red) in [https://github.com/BuilderIO/qwik/pull/5161](https://togithub.com/BuilderIO/qwik/pull/5161)
-   fix(core.d.ts): export HTMLAttributes and DevJSX to fix TS4023 issue … by [@&#8203;gparlakov](https://togithub.com/gparlakov) in [https://github.com/BuilderIO/qwik/pull/5141](https://togithub.com/BuilderIO/qwik/pull/5141)
-   fix: excludedPath defaults for netlify edge by [@&#8203;adamdbradley](https://togithub.com/adamdbradley) in [https://github.com/BuilderIO/qwik/pull/5163](https://togithub.com/BuilderIO/qwik/pull/5163)
-   fix(labs): filter out (group layouts) by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5171](https://togithub.com/BuilderIO/qwik/pull/5171)
-   feat(core): added symbol name to error by [@&#8203;shairez](https://togithub.com/shairez) in [https://github.com/BuilderIO/qwik/pull/5182](https://togithub.com/BuilderIO/qwik/pull/5182)
-   feat: Bun Adapter by [@&#8203;EamonHeffernan](https://togithub.com/EamonHeffernan) in [https://github.com/BuilderIO/qwik/pull/5129](https://togithub.com/BuilderIO/qwik/pull/5129)
-   fix(qwik-auth): don't overwrite response headers in qwik auth by [@&#8203;Aslemammad](https://togithub.com/Aslemammad) in [https://github.com/BuilderIO/qwik/pull/5180](https://togithub.com/BuilderIO/qwik/pull/5180)
-   docs(qwik-city): Clean up docs for bun adapter by [@&#8203;EamonHeffernan](https://togithub.com/EamonHeffernan) in [https://github.com/BuilderIO/qwik/pull/5185](https://togithub.com/BuilderIO/qwik/pull/5185)
-   chore(qwik-auth): v0.1.2 by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5186](https://togithub.com/BuilderIO/qwik/pull/5186)
-   docs: added firebase to menu.md by [@&#8203;the-r3aper7](https://togithub.com/the-r3aper7) in [https://github.com/BuilderIO/qwik/pull/5183](https://togithub.com/BuilderIO/qwik/pull/5183)
-   chore: release 1.2.12 by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5187](https://togithub.com/BuilderIO/qwik/pull/5187)
-   chore: update Prisma versions package.json by [@&#8203;ruheni](https://togithub.com/ruheni) in [https://github.com/BuilderIO/qwik/pull/5184](https://togithub.com/BuilderIO/qwik/pull/5184)
-   docs: fix routing page - add missing attributes. by [@&#8203;hamatoyogi](https://togithub.com/hamatoyogi) in [https://github.com/BuilderIO/qwik/pull/5188](https://togithub.com/BuilderIO/qwik/pull/5188)
-   fix(qwik-city): do not write into a destroyed stream by [@&#8203;tuurbo](https://togithub.com/tuurbo) in [https://github.com/BuilderIO/qwik/pull/5172](https://togithub.com/BuilderIO/qwik/pull/5172)
-   fix(qwik-city): wait until action fully complete before resolving its… by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5190](https://togithub.com/BuilderIO/qwik/pull/5190)

##### New Contributors

-   [@&#8203;ilianiv](https://togithub.com/ilianiv) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5159](https://togithub.com/BuilderIO/qwik/pull/5159)
-   [@&#8203;pipisso](https://togithub.com/pipisso) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5169](https://togithub.com/BuilderIO/qwik/pull/5169)
-   [@&#8203;sapphi-red](https://togithub.com/sapphi-red) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5161](https://togithub.com/BuilderIO/qwik/pull/5161)
-   [@&#8203;Aslemammad](https://togithub.com/Aslemammad) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5180](https://togithub.com/BuilderIO/qwik/pull/5180)

**Full Changelog**: QwikDev/qwik@v1.2.11...v1.2.12

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
@hamatoyogi hamatoyogi deleted the fix-video-elm branch October 27, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants