fix(qwik-auth): allow multiple set-cookie headers #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
mhevery
approved these changes
Sep 19, 2023
mhevery
reviewed
Sep 19, 2023
mhevery
approved these changes
Sep 19, 2023
|
This this need a new NPM release to be cut? |
Probably, since the other PR introduced a bug that this resolves. |
kodiakhq bot
referenced
this pull request
in ascorbic/unpic-img
Oct 8, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.12` -> `1.2.13`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.12/1.2.13) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.2.13`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.13) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.12...v1.2.13) #### What's Changed - fix(insights): wrapper style by [@​gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5193](https://togithub.com/BuilderIO/qwik/pull/5193) - docs: fix typos by [@​igorbabko](https://togithub.com/igorbabko) in [https://github.com/BuilderIO/qwik/pull/5195](https://togithub.com/BuilderIO/qwik/pull/5195) - fix(qwik-auth): allow multiple set-cookie headers by [@​ulic75](https://togithub.com/ulic75) in [https://github.com/BuilderIO/qwik/pull/5194](https://togithub.com/BuilderIO/qwik/pull/5194) - feat(insights): return prefetch list per route by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5197](https://togithub.com/BuilderIO/qwik/pull/5197) - feat(insights): return prefetch list per route by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5198](https://togithub.com/BuilderIO/qwik/pull/5198) - chore(qwik-auth): v0.1.3 by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5201](https://togithub.com/BuilderIO/qwik/pull/5201) - feat(cli): add barrel template to `new` command by [@​dapids](https://togithub.com/dapids) in [https://github.com/BuilderIO/qwik/pull/5202](https://togithub.com/BuilderIO/qwik/pull/5202) - docs: add `dimension.dev` to showcase by [@​necatikcl](https://togithub.com/necatikcl) in [https://github.com/BuilderIO/qwik/pull/5200](https://togithub.com/BuilderIO/qwik/pull/5200) - fix(core): Added StringSerializer for strings that start with the prefixes of serializers. by [@​genki](https://togithub.com/genki) in [https://github.com/BuilderIO/qwik/pull/5176](https://togithub.com/BuilderIO/qwik/pull/5176) - fix(serializers): fix for serialization of an empty set or map by [@​Varixo](https://togithub.com/Varixo) in [https://github.com/BuilderIO/qwik/pull/5209](https://togithub.com/BuilderIO/qwik/pull/5209) - docs: add qwik-spin-delay library by [@​harshmangalam](https://togithub.com/harshmangalam) in [https://github.com/BuilderIO/qwik/pull/5214](https://togithub.com/BuilderIO/qwik/pull/5214) - docs(ecosystem): add qwik-image library by [@​gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5216](https://togithub.com/BuilderIO/qwik/pull/5216) - chore: add prettier-plugin-tailwindcss to tailwind starter ([#​5217](https://togithub.com/BuilderIO/qwik/issues/5217)) by [@​nsdonato](https://togithub.com/nsdonato) in [https://github.com/BuilderIO/qwik/pull/5217](https://togithub.com/BuilderIO/qwik/pull/5217) - docs: Correct image size and CLS in resumable example by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5220](https://togithub.com/BuilderIO/qwik/pull/5220) - docs: fix url for useVisibleTask by [@​nsdonato](https://togithub.com/nsdonato) in [https://github.com/BuilderIO/qwik/pull/5223](https://togithub.com/BuilderIO/qwik/pull/5223) - feat: bootstrap integration adapter by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5222](https://togithub.com/BuilderIO/qwik/pull/5222) - chore: update file path in next-steps.tsx by [@​Craiqser](https://togithub.com/Craiqser) in [https://github.com/BuilderIO/qwik/pull/5212](https://togithub.com/BuilderIO/qwik/pull/5212) - refactor: remove extraneous isElement call by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5210](https://togithub.com/BuilderIO/qwik/pull/5210) - docs: fix edit this page for deprecated features by [@​nsdonato](https://togithub.com/nsdonato) in [https://github.com/BuilderIO/qwik/pull/5224](https://togithub.com/BuilderIO/qwik/pull/5224) - chore: update firebase starter to contemplate dist folder by [@​nsdonato](https://togithub.com/nsdonato) in [https://github.com/BuilderIO/qwik/pull/5225](https://togithub.com/BuilderIO/qwik/pull/5225) - feat(cachecontrol): add second `target` argument to cacheControl by [@​maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5226](https://togithub.com/BuilderIO/qwik/pull/5226) - fix: should SSR render if accept header includes */* by [@​SamVerschueren](https://togithub.com/SamVerschueren) in [https://github.com/BuilderIO/qwik/pull/5234](https://togithub.com/BuilderIO/qwik/pull/5234) - docs: fix 404 links by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5236](https://togithub.com/BuilderIO/qwik/pull/5236) - docs: Add frostytools.com to pages.json by [@​n8sabes](https://togithub.com/n8sabes) in [https://github.com/BuilderIO/qwik/pull/5239](https://togithub.com/BuilderIO/qwik/pull/5239) - docs: fix typo by [@​the-r3aper7](https://togithub.com/the-r3aper7) in [https://github.com/BuilderIO/qwik/pull/5241](https://togithub.com/BuilderIO/qwik/pull/5241) - chore(contributing.md): remove unnecessary step to test against docs … by [@​maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5244](https://togithub.com/BuilderIO/qwik/pull/5244) - chore(contributing.md): added info when package linking doesn't work by [@​maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5245](https://togithub.com/BuilderIO/qwik/pull/5245) - docs: Build Showcase by [@​n8sabes](https://togithub.com/n8sabes) in [https://github.com/BuilderIO/qwik/pull/5242](https://togithub.com/BuilderIO/qwik/pull/5242) - docs: documentation link and text for directory-based routing by [@​ryo-manba](https://togithub.com/ryo-manba) in [https://github.com/BuilderIO/qwik/pull/5246](https://togithub.com/BuilderIO/qwik/pull/5246) - feat(labs): Add json debugging tool by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5259](https://togithub.com/BuilderIO/qwik/pull/5259) - feat(core): Allow useContext in same elem as provider by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5258](https://togithub.com/BuilderIO/qwik/pull/5258) - docs(routing): add Link prefetch documentation (alternative) by [@​maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5248](https://togithub.com/BuilderIO/qwik/pull/5248) - docs(labs): document devtools/json by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5260](https://togithub.com/BuilderIO/qwik/pull/5260) - fix(starter): localize configuration by [@​gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5262](https://togithub.com/BuilderIO/qwik/pull/5262) - docs: fix typos by [@​igorbabko](https://togithub.com/igorbabko) in [https://github.com/BuilderIO/qwik/pull/5265](https://togithub.com/BuilderIO/qwik/pull/5265) - docs(integrations): add valibot to modular forms guide by [@​fabian-hiller](https://togithub.com/fabian-hiller) in [https://github.com/BuilderIO/qwik/pull/5252](https://togithub.com/BuilderIO/qwik/pull/5252) - docs: Update SSG documentation to run build instead of preview by [@​ibousfiha](https://togithub.com/ibousfiha) in [https://github.com/BuilderIO/qwik/pull/5269](https://togithub.com/BuilderIO/qwik/pull/5269) - fix(starter): localize container attribute by [@​tzdesign](https://togithub.com/tzdesign) in [https://github.com/BuilderIO/qwik/pull/5268](https://togithub.com/BuilderIO/qwik/pull/5268) - fix: A bug fix [#​5104](https://togithub.com/BuilderIO/qwik/issues/5104) by [@​Charlygraphy23](https://togithub.com/Charlygraphy23) in [https://github.com/BuilderIO/qwik/pull/5267](https://togithub.com/BuilderIO/qwik/pull/5267) - docs(state): Add 'key' prop to list items by [@​nicvazquez](https://togithub.com/nicvazquez) in [https://github.com/BuilderIO/qwik/pull/5250](https://togithub.com/BuilderIO/qwik/pull/5250) - docs: add note about `onRequest` middleware exported from `serverAuth$` by [@​jakovljevic-mladen](https://togithub.com/jakovljevic-mladen) in [https://github.com/BuilderIO/qwik/pull/5264](https://togithub.com/BuilderIO/qwik/pull/5264) - docs(labs): update path for devtools to include https by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5271](https://togithub.com/BuilderIO/qwik/pull/5271) - docs: updated phrasing for clarity by [@​bodhicodes](https://togithub.com/bodhicodes) in [https://github.com/BuilderIO/qwik/pull/5273](https://togithub.com/BuilderIO/qwik/pull/5273) - fix: Bun adapter polyfill and redirect fix by [@​EamonHeffernan](https://togithub.com/EamonHeffernan) in [https://github.com/BuilderIO/qwik/pull/5272](https://togithub.com/BuilderIO/qwik/pull/5272) - fix: Pr local dev docker by [@​SauravChanda](https://togithub.com/SauravChanda) in [https://github.com/BuilderIO/qwik/pull/5237](https://togithub.com/BuilderIO/qwik/pull/5237) - refactor(core): remove useContextBoundary by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5274](https://togithub.com/BuilderIO/qwik/pull/5274) - fix: shell script update in README file by [@​harshmangalam](https://togithub.com/harshmangalam) in [https://github.com/BuilderIO/qwik/pull/5275](https://togithub.com/BuilderIO/qwik/pull/5275) - docs: improve advanced routing documentation by [@​jakovljevic-mladen](https://togithub.com/jakovljevic-mladen) in [https://github.com/BuilderIO/qwik/pull/5276](https://togithub.com/BuilderIO/qwik/pull/5276) - chore: 1.2.13 by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5277](https://togithub.com/BuilderIO/qwik/pull/5277) #### New Contributors - [@​igorbabko](https://togithub.com/igorbabko) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5195](https://togithub.com/BuilderIO/qwik/pull/5195) - [@​dapids](https://togithub.com/dapids) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5202](https://togithub.com/BuilderIO/qwik/pull/5202) - [@​maiieul](https://togithub.com/maiieul) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5226](https://togithub.com/BuilderIO/qwik/pull/5226) - [@​SamVerschueren](https://togithub.com/SamVerschueren) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5234](https://togithub.com/BuilderIO/qwik/pull/5234) - [@​ryo-manba](https://togithub.com/ryo-manba) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5246](https://togithub.com/BuilderIO/qwik/pull/5246) - [@​ibousfiha](https://togithub.com/ibousfiha) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5269](https://togithub.com/BuilderIO/qwik/pull/5269) - [@​Charlygraphy23](https://togithub.com/Charlygraphy23) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5267](https://togithub.com/BuilderIO/qwik/pull/5267) - [@​nicvazquez](https://togithub.com/nicvazquez) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5250](https://togithub.com/BuilderIO/qwik/pull/5250) - [@​bodhicodes](https://togithub.com/bodhicodes) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5273](https://togithub.com/BuilderIO/qwik/pull/5273) - [@​SauravChanda](https://togithub.com/SauravChanda) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5237](https://togithub.com/BuilderIO/qwik/pull/5237) **Full Changelog**: QwikDev/qwik@v1.2.12...v1.2.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->
](https://renovatebot.com){kind=link}
This was referenced Dec 17, 2023
|
Heya, this PR still seems bugged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In PKCE OAuth authentication @auth/core sets two cookies (callback url and pkce code_verifier), but the second one was failing because of the condition added in #5180, which checked to see if the header already existed. This may be fine for most headers, but not for 'set-cookie' headers, in which multiple are allowed.
What is it?
Checklist: