Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cookbook): Add dark theme description #5255

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

Inaam-Ur-Rehman
Copy link
Contributor

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • [x ] My code follows the developer guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [x ] I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for qwik-insights canceled.

Name Link
🔨 Latest commit 7a67e2a
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6525823eebfea60008201fd9

@mhevery mhevery changed the title Dark theme support in Qwik docs(cookbook): Add dark theme description Oct 2, 2023
Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also let me know when this is ready for full review.

@@ -0,0 +1,138 @@
##Problem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing front matter.

@mhevery mhevery mentioned this pull request Oct 2, 2023
7 tasks
@zanettin zanettin added COMP: docs Improvements or additions to documentation WAITING FOR: user Further information is requested from the issue / pr opener labels Oct 3, 2023
Copy link
Contributor Author

@Inaam-Ur-Rehman Inaam-Ur-Rehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the frontmatter

@mhevery mhevery enabled auto-merge (squash) October 10, 2023 16:58
@mhevery mhevery merged commit 3516710 into QwikDev:main Oct 10, 2023
22 checks passed
Copy link
Contributor Author

@Inaam-Ur-Rehman Inaam-Ur-Rehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is typo in the contributor name. Can I change it

@gioboa
Copy link
Member

gioboa commented Oct 10, 2023

@Inaam-Ur-Rehman yes, you must create a new PR for that.

kodiakhq bot pushed a commit to ascorbic/unpic-img that referenced this pull request Oct 22, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.13` -> `1.2.14`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.13/1.2.14) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.2.13/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.2.13/1.2.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.2.14`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.14)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.13...v1.2.14)

##### What's Changed

-   refactor(e2e): Make tests more robust by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5279
-   fix(core): dynamic text signals by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5284
-   fix(qwik-city): ensure `server$` has correct `this` on server-side by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5278
-   docs(localization): auto-translation by [@&#8203;tzdesign](https://togithub.com/tzdesign) in [QwikDev/qwik#5287
-   fix: grammatical issue with Basic Projection Tutorial by [@&#8203;harishkrishnan24](https://togithub.com/harishkrishnan24) in [QwikDev/qwik#5286
-   docs: add note that Slots don't work without `component$()` by [@&#8203;jakovljevic-mladen](https://togithub.com/jakovljevic-mladen) in [QwikDev/qwik#5290
-   docs: Update pages.json to include QuoteMingle by [@&#8203;Decimalpointe](https://togithub.com/Decimalpointe) in [QwikDev/qwik#5285
-   docs(cookbook): Add dark theme description by [@&#8203;Inaam-Ur-Rehman](https://togithub.com/Inaam-Ur-Rehman) in [QwikDev/qwik#5255
-   chore: Prettier jsdoc by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5293
-   docs: fix broken link by [@&#8203;Craiqser](https://togithub.com/Craiqser) in [QwikDev/qwik#5294
-   docs: fix contributor name by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5296
-   docs: fix fastify link by [@&#8203;Craiqser](https://togithub.com/Craiqser) in [QwikDev/qwik#5298
-   chore: docs.sync + update pnpm by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5299
-   docs: added static site adapter by [@&#8203;the-r3aper7](https://togithub.com/the-r3aper7) in [QwikDev/qwik#4461
-   docs: Switch to using insights for generating bundles by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5302
-   fix: Add a missing CSS import to Storybook by [@&#8203;bebraw](https://togithub.com/bebraw) in [QwikDev/qwik#5308
-   docs: Add a missing link to qrl docs by [@&#8203;bebraw](https://togithub.com/bebraw) in [QwikDev/qwik#5307
-   chore: switch to vitest by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5300
-   fix(core): fix pause logic failing to capture component by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5309
-   chore: rollback drizzle to 0.28.3 by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5310
-   fix(core): prevent SSR rendering on images by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5313
-   docs: add qwik-morocco community image  by [@&#8203;ayoub9494](https://togithub.com/ayoub9494) in [QwikDev/qwik#5317
-   docs: add moroccan meetup group by [@&#8203;ayoub9494](https://togithub.com/ayoub9494) in [QwikDev/qwik#5314
-   docs: update authjs by [@&#8203;ayoub9494](https://togithub.com/ayoub9494) in [QwikDev/qwik#5316
-   fix(comment): Updated firebase entry comments to reference Firebase correctly by [@&#8203;vdemcak](https://togithub.com/vdemcak) in [QwikDev/qwik#5318
-   docs: fix component types in examples by [@&#8203;abstractalgo](https://togithub.com/abstractalgo) in [QwikDev/qwik#5319
-   feat(qwik-core): expose isSignal helper function by [@&#8203;octoper](https://togithub.com/octoper) in [QwikDev/qwik#4749
-   docs: fix syntax error in mdx tags example by [@&#8203;ihaback](https://togithub.com/ihaback) in [QwikDev/qwik#5324
-   fix: docs Cloudflare build by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5329
-   fix: Bump pandacss version to a Qwik compatible one by [@&#8203;NiklasPor](https://togithub.com/NiklasPor) in [QwikDev/qwik#5330
-   chore: upgrade supabase version to 2.38.1 by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5331
-   refactor(core): No $slotParent$ by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5263
-   fix: [@&#8203;builder](https://togithub.com/builder).io/qwik/build should not SSR render by [@&#8203;mpeg](https://togithub.com/mpeg) in [QwikDev/qwik#5326
-   chore: 1.2.14 by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5332

##### New Contributors

-   [@&#8203;Decimalpointe](https://togithub.com/Decimalpointe) made their first contribution in [QwikDev/qwik#5285
-   [@&#8203;Inaam-Ur-Rehman](https://togithub.com/Inaam-Ur-Rehman) made their first contribution in [QwikDev/qwik#5255
-   [@&#8203;bebraw](https://togithub.com/bebraw) made their first contribution in [QwikDev/qwik#5308
-   [@&#8203;ayoub9494](https://togithub.com/ayoub9494) made their first contribution in [QwikDev/qwik#5317
-   [@&#8203;vdemcak](https://togithub.com/vdemcak) made their first contribution in [QwikDev/qwik#5318
-   [@&#8203;abstractalgo](https://togithub.com/abstractalgo) made their first contribution in [QwikDev/qwik#5319
-   [@&#8203;ihaback](https://togithub.com/ihaback) made their first contribution in [QwikDev/qwik#5324
-   [@&#8203;NiklasPor](https://togithub.com/NiklasPor) made their first contribution in [QwikDev/qwik#5330
-   [@&#8203;mpeg](https://togithub.com/mpeg) made their first contribution in [QwikDev/qwik#5326

**Full Changelog**: QwikDev/qwik@v1.2.13...v1.2.14

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation WAITING FOR: user Further information is requested from the issue / pr opener
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants