fix: @builder.io/qwik/build should not SSR render #5326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
|
Thanks! |
kodiakhq bot
referenced
this pull request
in ascorbic/unpic-img
Oct 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.13` -> `1.2.14`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.13/1.2.14) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.2.14`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.14) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.13...v1.2.14) ##### What's Changed - refactor(e2e): Make tests more robust by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5279](https://togithub.com/BuilderIO/qwik/pull/5279) - fix(core): dynamic text signals by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5284](https://togithub.com/BuilderIO/qwik/pull/5284) - fix(qwik-city): ensure `server$` has correct `this` on server-side by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5278](https://togithub.com/BuilderIO/qwik/pull/5278) - docs(localization): auto-translation by [@​tzdesign](https://togithub.com/tzdesign) in [https://github.com/BuilderIO/qwik/pull/5287](https://togithub.com/BuilderIO/qwik/pull/5287) - fix: grammatical issue with Basic Projection Tutorial by [@​harishkrishnan24](https://togithub.com/harishkrishnan24) in [https://github.com/BuilderIO/qwik/pull/5286](https://togithub.com/BuilderIO/qwik/pull/5286) - docs: add note that Slots don't work without `component$()` by [@​jakovljevic-mladen](https://togithub.com/jakovljevic-mladen) in [https://github.com/BuilderIO/qwik/pull/5290](https://togithub.com/BuilderIO/qwik/pull/5290) - docs: Update pages.json to include QuoteMingle by [@​Decimalpointe](https://togithub.com/Decimalpointe) in [https://github.com/BuilderIO/qwik/pull/5285](https://togithub.com/BuilderIO/qwik/pull/5285) - docs(cookbook): Add dark theme description by [@​Inaam-Ur-Rehman](https://togithub.com/Inaam-Ur-Rehman) in [https://github.com/BuilderIO/qwik/pull/5255](https://togithub.com/BuilderIO/qwik/pull/5255) - chore: Prettier jsdoc by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5293](https://togithub.com/BuilderIO/qwik/pull/5293) - docs: fix broken link by [@​Craiqser](https://togithub.com/Craiqser) in [https://github.com/BuilderIO/qwik/pull/5294](https://togithub.com/BuilderIO/qwik/pull/5294) - docs: fix contributor name by [@​gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5296](https://togithub.com/BuilderIO/qwik/pull/5296) - docs: fix fastify link by [@​Craiqser](https://togithub.com/Craiqser) in [https://github.com/BuilderIO/qwik/pull/5298](https://togithub.com/BuilderIO/qwik/pull/5298) - chore: docs.sync + update pnpm by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5299](https://togithub.com/BuilderIO/qwik/pull/5299) - docs: added static site adapter by [@​the-r3aper7](https://togithub.com/the-r3aper7) in [https://github.com/BuilderIO/qwik/pull/4461](https://togithub.com/BuilderIO/qwik/pull/4461) - docs: Switch to using insights for generating bundles by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5302](https://togithub.com/BuilderIO/qwik/pull/5302) - fix: Add a missing CSS import to Storybook by [@​bebraw](https://togithub.com/bebraw) in [https://github.com/BuilderIO/qwik/pull/5308](https://togithub.com/BuilderIO/qwik/pull/5308) - docs: Add a missing link to qrl docs by [@​bebraw](https://togithub.com/bebraw) in [https://github.com/BuilderIO/qwik/pull/5307](https://togithub.com/BuilderIO/qwik/pull/5307) - chore: switch to vitest by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5300](https://togithub.com/BuilderIO/qwik/pull/5300) - fix(core): fix pause logic failing to capture component by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5309](https://togithub.com/BuilderIO/qwik/pull/5309) - chore: rollback drizzle to 0.28.3 by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5310](https://togithub.com/BuilderIO/qwik/pull/5310) - fix(core): prevent SSR rendering on images by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5313](https://togithub.com/BuilderIO/qwik/pull/5313) - docs: add qwik-morocco community image by [@​ayoub9494](https://togithub.com/ayoub9494) in [https://github.com/BuilderIO/qwik/pull/5317](https://togithub.com/BuilderIO/qwik/pull/5317) - docs: add moroccan meetup group by [@​ayoub9494](https://togithub.com/ayoub9494) in [https://github.com/BuilderIO/qwik/pull/5314](https://togithub.com/BuilderIO/qwik/pull/5314) - docs: update authjs by [@​ayoub9494](https://togithub.com/ayoub9494) in [https://github.com/BuilderIO/qwik/pull/5316](https://togithub.com/BuilderIO/qwik/pull/5316) - fix(comment): Updated firebase entry comments to reference Firebase correctly by [@​vdemcak](https://togithub.com/vdemcak) in [https://github.com/BuilderIO/qwik/pull/5318](https://togithub.com/BuilderIO/qwik/pull/5318) - docs: fix component types in examples by [@​abstractalgo](https://togithub.com/abstractalgo) in [https://github.com/BuilderIO/qwik/pull/5319](https://togithub.com/BuilderIO/qwik/pull/5319) - feat(qwik-core): expose isSignal helper function by [@​octoper](https://togithub.com/octoper) in [https://github.com/BuilderIO/qwik/pull/4749](https://togithub.com/BuilderIO/qwik/pull/4749) - docs: fix syntax error in mdx tags example by [@​ihaback](https://togithub.com/ihaback) in [https://github.com/BuilderIO/qwik/pull/5324](https://togithub.com/BuilderIO/qwik/pull/5324) - fix: docs Cloudflare build by [@​gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5329](https://togithub.com/BuilderIO/qwik/pull/5329) - fix: Bump pandacss version to a Qwik compatible one by [@​NiklasPor](https://togithub.com/NiklasPor) in [https://github.com/BuilderIO/qwik/pull/5330](https://togithub.com/BuilderIO/qwik/pull/5330) - chore: upgrade supabase version to 2.38.1 by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5331](https://togithub.com/BuilderIO/qwik/pull/5331) - refactor(core): No $slotParent$ by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5263](https://togithub.com/BuilderIO/qwik/pull/5263) - fix: [@​builder](https://togithub.com/builder).io/qwik/build should not SSR render by [@​mpeg](https://togithub.com/mpeg) in [https://github.com/BuilderIO/qwik/pull/5326](https://togithub.com/BuilderIO/qwik/pull/5326) - chore: 1.2.14 by [@​mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5332](https://togithub.com/BuilderIO/qwik/pull/5332) ##### New Contributors - [@​Decimalpointe](https://togithub.com/Decimalpointe) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5285](https://togithub.com/BuilderIO/qwik/pull/5285) - [@​Inaam-Ur-Rehman](https://togithub.com/Inaam-Ur-Rehman) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5255](https://togithub.com/BuilderIO/qwik/pull/5255) - [@​bebraw](https://togithub.com/bebraw) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5308](https://togithub.com/BuilderIO/qwik/pull/5308) - [@​ayoub9494](https://togithub.com/ayoub9494) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5317](https://togithub.com/BuilderIO/qwik/pull/5317) - [@​vdemcak](https://togithub.com/vdemcak) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5318](https://togithub.com/BuilderIO/qwik/pull/5318) - [@​abstractalgo](https://togithub.com/abstractalgo) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5319](https://togithub.com/BuilderIO/qwik/pull/5319) - [@​ihaback](https://togithub.com/ihaback) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5324](https://togithub.com/BuilderIO/qwik/pull/5324) - [@​NiklasPor](https://togithub.com/NiklasPor) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5330](https://togithub.com/BuilderIO/qwik/pull/5330) - [@​mpeg](https://togithub.com/mpeg) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5326](https://togithub.com/BuilderIO/qwik/pull/5326) **Full Changelog**: QwikDev/qwik@v1.2.13...v1.2.14 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As per bug #5325
@builder.io/qwik/buildis a special url that should not ssr render. #5234 introduced new logic onshouldSsrRenderthat causes it to ssr render, which breaks things.fix #5325
What is it?
Description
This PR adds a new conditional to
shouldSsrRendersimilar to the existing ones forvite-ping,html-proxyand__open-in-editorfor@builder.io/qwik/buildthat fixes the issue.Use cases and why
As per #5325, the library starter template throws an error when interacting with any client side code on v1.2.13
Checklist: