Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken Markdown on Astro Docs page #5830

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

LorisSigrist
Copy link
Contributor

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

The Astro page included some broken Markdown that rendered parts of the markdown source as a code block. This PR fixes that.

Screenshot 2024-02-07 at 09 54 41

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • [N/A] I have made corresponding changes to the documentation
  • [N/A] Added new tests to cover the fix / functionality

Copy link

netlify bot commented Feb 7, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e34d22a

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LorisSigrist nice catch

@gioboa gioboa enabled auto-merge (squash) February 7, 2024 09:02
@gioboa gioboa merged commit 3eb2ed5 into QwikDev:main Feb 7, 2024
22 checks passed
kodiakhq bot referenced this pull request in ascorbic/unpic-img Feb 18, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.4.4` -> `1.4.5`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.4.4/1.4.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.4.4/1.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.4.4/1.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.4.5`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.5)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.4...v1.4.5)

#### What's Changed

-   docs: Fix broken Markdown on Astro Docs page by [@&#8203;LorisSigrist](https://togithub.com/LorisSigrist) in [https://github.com/BuilderIO/qwik/pull/5830](https://togithub.com/BuilderIO/qwik/pull/5830)
-   fix: qwik-react peer version by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5831](https://togithub.com/BuilderIO/qwik/pull/5831)
-   docs: update index.mdx to account for bun start crash on win by [@&#8203;codethinki](https://togithub.com/codethinki) in [https://github.com/BuilderIO/qwik/pull/5834](https://togithub.com/BuilderIO/qwik/pull/5834)
-   docs(speculative-module-fetching): remove that it doesn't work in preview because it does by [@&#8203;maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5836](https://togithub.com/BuilderIO/qwik/pull/5836)
-   fix(qwik-city): don't cache errors by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5839](https://togithub.com/BuilderIO/qwik/pull/5839)
-   docs(showcase): added Sasthya Seba - Healthcare service provider. by [@&#8203;iamriajul](https://togithub.com/iamriajul) in [https://github.com/BuilderIO/qwik/pull/5838](https://togithub.com/BuilderIO/qwik/pull/5838)
-   chore: Update 🐼 PandaCSS integration dev dependenc by [@&#8203;mrhoodz](https://togithub.com/mrhoodz) in [https://github.com/BuilderIO/qwik/pull/5842](https://togithub.com/BuilderIO/qwik/pull/5842)
-   fix(ssr): task sorting during SSR by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5847](https://togithub.com/BuilderIO/qwik/pull/5847)
-   chore: 1.4.5 by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5848](https://togithub.com/BuilderIO/qwik/pull/5848)

#### New Contributors

-   [@&#8203;LorisSigrist](https://togithub.com/LorisSigrist) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5830](https://togithub.com/BuilderIO/qwik/pull/5830)
-   [@&#8203;codethinki](https://togithub.com/codethinki) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5834](https://togithub.com/BuilderIO/qwik/pull/5834)

**Full Changelog**: QwikDev/qwik@v1.4.4...v1.4.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE5MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants