New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(qwik-city): spa-shim.ts import scripts from wrong path #5954

Merged

wmertens merged 1 commit into QwikDev:main from blueagler:codespace-musical-waddle-j7v944v9r593pjg

Mar 6, 2024

Contributor

blueagler commented Mar 5, 2024

Overview

What is it?

Feature / enhancement
Bug
Docs / tests / types / typos

Description

spa-shim.ts does not respect q:base attribute when importing script

In a subpath, for example http://localhost:3000/blog/
It will import the script from http://localhost:3000/blog/eg.js
Not from http://localhost:3000/build/eg.js

Use cases and why

Just a mistype maybe

1. One use case
1. Another use case

Checklist:

My code follows the developer guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
Added new tests to cover the fix / functionality


          Update import path in spa-shim.ts

fee1893

netlify bot commented Mar 5, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`fee1893`

wmertens approved these changes

View reviewed changes

wmertens merged commit c574527 into QwikDev:main

22 checks passed

Member

wmertens commented Mar 6, 2024

Thanks!

gioboa approved these changes

View reviewed changes

Member

gioboa left a comment

Thanks @blueagler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment