Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): add support for AVIF images #6090

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

danielvaijk
Copy link
Contributor

fix #6089

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Image resizing optimization is done using the image-size dependency. There was a case missing to handle AVIF image types/extensions, which caused the optimizer server to return a 500 to GET requests to a __image-info endpoint.

Use cases and why

There should be no errors when AVIF images are being served on a page (during development).

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Apr 5, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8b91fb5

@wmertens wmertens enabled auto-merge (rebase) April 5, 2024 22:48
@wmertens wmertens merged commit adb4c0c into QwikDev:main Apr 5, 2024
21 of 22 checks passed
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @danielvaijk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] Image size optimizer server unable to handle AVIF images.
3 participants