chore(build): refactor and increase sanity #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmertens
force-pushed
the
build-refactor
branch
10 times, most recently
from
8add9a1 to
61cd209
Compare
now all packages only use other built packages, no source imports. - upgrade typescript + fixups - add a version override so the API extractor uses the same TS version - make typescript use bundler semantics for imports - remove most TS path overrides, keep only per-package internal ones - change build for qwik-labs to use vite + dts plugin - build types and api in steps: qwik, then qwik-city+qwik-react, then the rest - change the dev server to remove workarounds - add flag to disable vendor scan, was causing e2e issues - some type fixes
Playwright doesn't play that nice with NixOS because it downloads binaries that require libs that aren't always available. Nix has a special package with playwright browsers. We don't use the latest features of Playwright, so lagging behind is fine and it limits the downloads required.
wmertens
force-pushed
the
build-refactor
branch
15 times, most recently
from
02c47d3 to
137d925
Compare
the previous setup assumed that the display components would render twice before being visible but now they're only rendered once.
wmertens
force-pushed
the
build-refactor
branch
from
2daf392 to
7516cfd
Compare
mhevery
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now all packages only use other built packages, no source imports.
As a bonus, the total runtime for CI went from 50+ minutes to 40-ish, realtime from about 25 to about 15. Mostly thanks to way faster builds and somewhat faster E2E tests.