feat(qwikloader): emit error #6254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying qwik-docs with
|
| Latest commit: |
4be3d27
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89319d84.qwik-8nx.pages.dev |
| Branch Preview URL: | https://feat-qwikloader-emit-error.qwik-8nx.pages.dev |
PatrickJS
force-pushed
the
feat-qwikloader-emit-error
branch
from
2c428f7 to
fd948b0
Compare
|
Is qerror with the data specific enough to know that it was a symbol error? I think we should also have a default handler in qwik city that hard reloads the page when the error is 404 |
|
yeah, I'm thinking we can use this and add it to the import for a hard reload (to fix the other problem). this was meant for detecting an error |
|
@wmertens ok I added an importError check we can later add a listener to check for it and reload for prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3716