feat(qwik-city): scroll restoration any element #6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJS
approved these changes
May 7, 2024
|
awesome! |
PatrickJS
changed the title
documentElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
The scroll restoration is very neat feature of the Qwik-city.
I would like to add a feat to change the scroller element from the
documentElementto other one.Use cases and why
Nowadays, there are various ways to layout a web page.
Particularly when using CSS Grid and other modern techniques, it's common to have a scrollable element other than the
documentElementas the main scrolling container of the page.This update is intended to support such cases.
If you want to specify the scroller element, you can do it by set its
idto{QWIK_CITY_SCROLLER}.Otherwise no changes happen.
Checklist: