Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates useResource description in readme.md #6354

Merged
merged 1 commit into from
May 22, 2024

Conversation

greatgraphicdesign
Copy link
Contributor

Mentions to avoid using a try/catch statement in useResource and why.

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

Until I removed the try/catch statement in useResource$, Resource was not providing an accurate onRejected status.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Mentions to avoid using a try/catch statement in useResource and why.
Copy link

netlify bot commented May 22, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5371c31

@greatgraphicdesign greatgraphicdesign changed the title Updates useResource description in readme.md docs: Updates useResource description in readme.md May 22, 2024
@PatrickJS PatrickJS merged commit c215977 into QwikDev:main May 22, 2024
21 of 22 checks passed
@gioboa
Copy link
Member

gioboa commented May 22, 2024

Thanks @greatgraphicdesign for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants