Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for deep property of useStore to match the new default #6383

Merged
merged 1 commit into from
May 24, 2024

Conversation

Joristdh
Copy link
Contributor

@Joristdh Joristdh commented May 24, 2024

Overview

Changes are made in JSDoc, API json and API docs.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

In #3678 the useStore is made recursive by default. The JSDoc and API description for the deep property of UseStoreOptions were not yet updated to match this.

Use cases and why

The conflicting docs can be confusing as it insinuates that deep reactivity still has to be enabled manually. Especially the outdated JSDoc makes for a confusing IntelliSense in code editors.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Changes are made in JSDoc, API json and API docs
Copy link

netlify bot commented May 24, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3984b51

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @Joristdh
you attached the PR that changed this flag, you rock 🚀

@gioboa gioboa enabled auto-merge (squash) May 24, 2024 20:28
@gioboa gioboa merged commit f4a8929 into QwikDev:main May 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants