Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added ability to publish test packages #6389

Merged
merged 22 commits into from
Jun 7, 2024
Merged

ci: added ability to publish test packages #6389

merged 22 commits into from
Jun 7, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented May 25, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Added pkg.pr.new to be able to test PRs and latest main commits without the need to release a new version each time.

Great for testing new fixes before they go live

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@shairez shairez requested a review from a team as a code owner May 25, 2024 15:35
Copy link

netlify bot commented May 25, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit b720c44
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/66625108418f8a0008574276
😎 Deploy Preview https://deploy-preview-6389--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-pages bot commented May 25, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cbcb17
Status: ✅  Deploy successful!
Preview URL: https://9b60cd90.qwik-8nx.pages.dev
Branch Preview URL: https://pr-pkg-pr-new.qwik-8nx.pages.dev

View logs

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@@ -481,6 +494,9 @@ jobs:
packages/qwik-labs/vite/
packages/qwik-labs/package.json
if-no-files-found: error
- run: pnpx pkg-pr-new publish --compact ./packages/qwik/dist ./packages/qwik-city/dist dist-dev-eslint-plugin-qwik dist-dev-create-qwik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes these dist-dev directories?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the upload-artifacts task from the job before

@shairez shairez marked this pull request as draft May 25, 2024 17:32
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. I really like this idea.

package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@shairez
Copy link
Contributor Author

shairez commented May 26, 2024

Currently pkg.pr.new has a size limit we exceed.
until we'll sort it out, this PR stays in draft mode

@wmertens
Copy link
Member

wmertens commented Jun 2, 2024

@shairez we can fix the size limit by not shipping the native plugins, only the wasm. For that, it should skip the native builds and you should overwrite packages/qwik/src/optimizer/src/qwik-binding-map.ts so it exports {}.

@shairez shairez marked this pull request as ready for review June 3, 2024 20:31
Copy link

pkg-pr-new bot commented Jun 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (b720c44)

npm i https://pkg.pr.new/@builder.io/qwik@6389

@builder.io/qwik-city (b720c44)

npm i https://pkg.pr.new/@builder.io/qwik-city@6389

eslint-plugin-qwik (b720c44)

npm i https://pkg.pr.new/eslint-plugin-qwik@6389

create-qwik (b720c44)

npm i https://pkg.pr.new/create-qwik@6389

@shairez shairez marked this pull request as ready for review June 7, 2024 00:15
@shairez shairez merged commit 1b1429b into main Jun 7, 2024
23 of 24 checks passed
@shairez shairez deleted the pr-pkg-pr-new branch June 7, 2024 00:18
@Aslemammad
Copy link
Contributor

Thank you so much team!

- name: Publish packages for testing
run: pnpm dlx pkg-pr-new@0.0.8 publish --compact --pnpm ./packages/qwik/dist ./packages/qwik-city/lib ./packages/eslint-plugin-qwik/dist ./packages/create-qwik/dist
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore, FYI :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the github token?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

@shairez
Copy link
Contributor Author

shairez commented Jun 7, 2024

Thanks so much @Aslemammad for the awesome job you did in creating this and fixing it to make it work for us as well
Very much appreciated! 🙏🙌

@Aslemammad
Copy link
Contributor

🙌🙌🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants