Skip to content

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Sep 5, 2025

Close #7852

With a catch all route, if a file is missing eg. /build/missing_file.js the process is trying to match a route for the path. Right now, even if is doing the wrong logic, is returning 301. With this change we will return 404.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner September 5, 2025 09:07
Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: b0084a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 5, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview afbbd60

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit ca897c5 into QwikDev:main Sep 5, 2025
50 of 54 checks passed
@gioboa gioboa deleted the fix/7852 branch September 17, 2025 09:13
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
@github-actions github-actions bot mentioned this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] Catch-all route causes all 404 static resources to get 301 to Slashed route
2 participants