Skip to content

fix(repl): small things #7922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

fix(repl): small things #7922

merged 2 commits into from
Sep 8, 2025

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Sep 8, 2025

  • url wasn't updating
  • bundle worker not starting wasn't noticed

@wmertens
fix(repl): notice bundle worker errors
37066a7
@wmertens
fix(repl): make share url work again
93a6de0 
before, we were replacing the files entirely, so now we need to track deeper.
@wmertens wmertens requested a review from a team as a code owner September 8, 2025 05:16
@wmertens wmertens enabled auto-merge September 8, 2025 05:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2025

⚠️ No Changeset found

Latest commit: 93a6de0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 93a6de0

gioboa
gioboa approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏
Thanks for your commitment 💯

@wmertens wmertens merged commit ef49a82 into main Sep 8, 2025
17 checks passed
@wmertens wmertens deleted the repl-better branch September 8, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmertens @gioboa