Skip to content

test: add ssrstream with ssrraw unit test #7934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2025
Merged

test: add ssrstream with ssrraw unit test #7934

merged 2 commits into from
Sep 10, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Sep 10, 2025

Adding test for ssrstream together with ssrraw

@Varixo Varixo self-assigned this Sep 10, 2025
@Varixo Varixo requested a review from a team as a code owner September 10, 2025 09:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4dc0d60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gioboa
gioboa approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @Varixo

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 10, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7934

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7934

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7934

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7934

commit: 4dc0d60

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 4dc0d60

@Varixo Varixo force-pushed the v2-add-test-ssrstream-html branch from 8e6657e to 4dc0d60 Compare September 10, 2025 10:07
@Varixo Varixo requested review from a team as code owners September 10, 2025 10:07
gioboa
gioboa approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@gioboa gioboa requested a review from wmertens September 10, 2025 10:24
@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Sep 10, 2025
@Varixo Varixo merged commit 00fc7a7 into build/v2 Sep 10, 2025
20 checks passed
@Varixo Varixo deleted the v2-add-test-ssrstream-html branch September 10, 2025 18:45
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

@wmertens wmertens Awaiting requested review from wmertens

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Varixo @gioboa