Skip to content

Conversation

sashkashishka
Copy link
Contributor

What is it?

E2E tests for qwik react integration issue with unmounting #7542.

Description

Tests that checks whether the react calls unmount callbacks when qwikify wrapper unmounts.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@sashkashishka sashkashishka requested a review from a team as a code owner September 13, 2025 08:08
Copy link

changeset-bot bot commented Sep 13, 2025

🦋 Changeset detected

Latest commit: f6369a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7950
npm i https://pkg.pr.new/@builder.io/qwik-city@7950
npm i https://pkg.pr.new/eslint-plugin-qwik@7950
npm i https://pkg.pr.new/create-qwik@7950

commit: f6369a0

Copy link
Contributor

github-actions bot commented Sep 13, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview f6369a0

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see, thanks!

LGTM

@wmertens wmertens merged commit 7e2ece2 into QwikDev:main Sep 13, 2025
19 checks passed
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your commitment 🎉
@sashkashishka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants