Skip to content

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Oct 4, 2025

Always add unblocked chore to chores queue on vnode. This is needed to correctly find blocking chore later.

@Varixo Varixo self-assigned this Oct 4, 2025
@Varixo Varixo requested a review from a team as a code owner October 4, 2025 09:12
Copy link

changeset-bot bot commented Oct 4, 2025

🦋 Changeset detected

Latest commit: b6eebcd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo moved this from Backlog to In progress in Qwik Development Oct 4, 2025
@Varixo Varixo force-pushed the v2-fix-unblocking-chores branch from 28bd147 to fcc4c2c Compare October 4, 2025 09:14
Copy link

pkg-pr-new bot commented Oct 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8028
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8028
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8028
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8028

commit: b6eebcd

Copy link
Contributor

github-actions bot commented Oct 4, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b6eebcd

@Varixo Varixo linked an issue Oct 4, 2025 that may be closed by this pull request
@Varixo Varixo moved this from In progress to Waiting For Review in Qwik Development Oct 4, 2025
@thejackshelton
Copy link
Member

Giving a heads up that when I clicked the deployment preview for this PR, when I clicked the Search button at the top right, the entire page became inert

@Varixo Varixo force-pushed the v2-fix-unblocking-chores branch from c476d51 to ed420dd Compare October 5, 2025 16:58
@Varixo Varixo force-pushed the v2-fix-unblocking-chores branch from ed420dd to b6eebcd Compare October 5, 2025 17:21
@Varixo
Copy link
Member Author

Varixo commented Oct 5, 2025

Giving a heads up that when I clicked the deployment preview for this PR, when I clicked the Search button at the top right, the entire page became inert

should be fixed

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍄

@wmertens wmertens merged commit 44ea824 into build/v2 Oct 5, 2025
48 of 106 checks passed
@wmertens wmertens deleted the v2-fix-unblocking-chores branch October 5, 2025 20:44
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[🐞] [v2] Context breaks when using higher order components in CSR
3 participants