Turtlebot3 setup motors #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to make the code a little more robust to handle when the servos are somewhat setup. So in different places the code knows which servo id it is looking for and if found it tries to use that one. Where before if you had servo ID ROBOTIS-GIT#1 and ROBOTIS-GIT#2 and was trying to setup left, it would grab the last servo found ROBOTIS-GIT#2 and then set it's id to ROBOTIS-GIT#1... Also used ping to know if the specific servo was found that is expected for the test servo cases and only does this at baud of 1000000 as that is what turtle expects
Make it work more with Arduino. So most of the dynamixel sdk methods show up as known Arduino methods and also added a few keywords
A few more literals...
Somehow lost the line, that reset the baud rate back down to 57600 if the ping found the servo at that speed. Also made the sketch work on OpenCM9.04 as well. So if one needed to do it and did not want to get to their OpenCR board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to make the code a little more robust to handle when the servos are somewhat setup.
So in different places the code knows which servo id it is looking for and if found it tries to use that one. Where before if you had servo ID #1 and #2 and was trying to setup left, it would grab the last servo found #2 and then set it's id to #1...
Also used ping to know if the specific servo was found that is expected for the test servo cases and only does this at baud of 1000000 as that is what turtle expects
Also defined some of the methods and the like in the keywords.txt, so they show up as Arduino things...