Make sure we capture errors of CI #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error code propagation in the distributed test runner to ensure CI properly captures pytest failures. Previously, pytest failures in worker processes were being swallowed and not propagated to the main process, causing CI to incorrectly report success even when tests failed.
Key changes:
- Added error code checking and propagation in worker processes
- Added exception handling in main process to capture and re-raise worker exit codes
github-actions
bot
added
in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI was swallowing pytests errors
Technical Details
PR makes sure we return error code from pytest
Test Plan
Test Result
Submission Checklist