Skip to content

Make sure we capture errors of CI #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

Make sure we capture errors of CI #173

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1b99e8
Make sure we capture errors of CI
mawad-amd Sep 19, 2025
82459fb
Apply Ruff auto-fixes
github-actions[bot] Sep 19, 2025
fac76e3
Break test for testing
mawad-amd Sep 19, 2025
6467ffb
Undo breaking tests
mawad-amd Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion tests/run_tests_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ def _distributed_worker(rank, world_size, test_file, pytest_args):
try:
# Run pytest directly in this process
exit_code = pytest.main([test_file] + pytest_args)
# If tests failed, exit with the failure code
if exit_code != 0:
sys.exit(exit_code)
return exit_code
finally:
# Restore original argv
Expand Down Expand Up @@ -82,7 +85,19 @@ def main():
print(f"args={args}, test_file={test_file}, pytest_args={pytest_args}")

# Run all tests within a single distributed process group
mp.spawn(_distributed_worker, args=(num_ranks, test_file, pytest_args), nprocs=num_ranks, join=True)
try:
mp.spawn(
_distributed_worker,
args=(num_ranks, test_file, pytest_args),
nprocs=num_ranks,
join=True,
)
except SystemExit as e:
# Catch sys.exit() from worker and return same exit code
sys.exit(e.code if isinstance(e.code, int) else 1)
except Exception:
# Any other unhandled exception = failure
sys.exit(1)


if __name__ == "__main__":
Expand Down
Loading