-
Notifications
You must be signed in to change notification settings - Fork 19
Sync cache modifiers branch with main and add cache modifiers to copy function #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mawad-amd
merged 29 commits into
muhaawad/cache-modifiers
from
copilot/sync-cache-modifiers-with-main
Oct 11, 2025
Merged
Sync cache modifiers branch with main and add cache modifiers to copy function #230
mawad-amd
merged 29 commits into
muhaawad/cache-modifiers
from
copilot/sync-cache-modifiers-with-main
Oct 11, 2025
+5,938
−378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Octa Trifan <octrifan@amd.com> Co-authored-by: Muhammad Awad <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… test coverage (#177) Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Eric Eaton <erieaton@amd.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: Octa Trifan <octrifan@amd.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Muhammad Awad <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Osama <osama94@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Osama <osama94@gmail.com> Co-authored-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…EVICES (#190) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Muhammad Awad <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Osama <osama94@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…198) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
…#203) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…test segfaults (#219) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
mawad-amd
approved these changes
Oct 11, 2025
Copilot finished work on behalf of
mawad-amd
October 11, 2025 05:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR merges the latest changes from
main
into the cache-modifiers branch and implements cache modifier support for the newly addedcopy()
function. All changes maintain backward compatibility through optional parameters.Changes
Merged main branch
copy()
function (Implements copy function #113) and its testsCache Modifier Implementation
Added cache modifier support to the
copy()
function to match the existingget()
andput()
functions:Supported Cache Modifiers
Load cache modifiers:
None
or".ca"
(default) - Cache at all levels (CU, L2, LLC) with LRU policy".cg"
- Bypasses CU (L1) cache, streams through L2".cv"
- Bypasses all GPU caches, fetches from system memoryStore cache modifiers:
None
or".wb"
(default) - Write-back caching at all levels".cg"
- Cache Global, stored through L1 → L2 → LLC".cs"
- Cache Streaming, bypasses L1, streamed through L2".wt"
- Write-Through, bypasses L1 and L2Testing
Added comprehensive test coverage in
test_copy_cache_modifiers.py
that validates all combinations of load and store cache modifiers, following the same pattern as existing cache modifier tests.Documentation
Updated function docstrings with detailed descriptions of cache modifier behavior, following the CDNA ISA specifications for instruction-level cache control.
Backward Compatibility
All changes are fully backward compatible:
None
Example Usage
Original prompt
Fixes #229
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.