Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain upgrades #10201

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Toolchain upgrades #10201

merged 1 commit into from
Apr 28, 2021

Conversation

xddxd
Copy link
Contributor

@xddxd xddxd commented Apr 27, 2021

Switches to a Ubuntu 18.04 docker container for Linux builds. Now it uses GCC 10.3 and Clang 12 for compilation, CMake (minimum as well) and Ninja versions are also bumped. Also bumps the LLVM submodule to a later commit. Removes the xcb hack, bumps minimum compiler versions. Switches BSD to Clang 12.

edit: do not merge yet, waiting on hcorion to push a newer docker image.

@Megamouse Megamouse added Build and CI Anything related to the build process and continuous integration OS: Linux labels Apr 27, 2021
@Nekotekina
Copy link
Member

So it works now? Maybe bump minimal required compiler versions as well.

@xddxd
Copy link
Contributor Author

xddxd commented Apr 28, 2021

Done. For documentation purposes: I tested the removal of the xcb hack and it worked fine on my manjaro system with an amd gpu.

@Nekotekina
Copy link
Member

BSD build tries to fetch llvm-11, I guess if it can be fixed now we are good to go.

@hcorion
Copy link
Member

hcorion commented Apr 28, 2021

We should also bump minimum CMake, but that can be done in a follow-up pr

@xddxd xddxd force-pushed the bionic branch 2 times, most recently from d452f53 to 4c567a5 Compare April 28, 2021 15:20
@xddxd xddxd changed the title Ubuntu bionic build Toolchain upgrades Apr 28, 2021
@xddxd
Copy link
Contributor Author

xddxd commented Apr 28, 2021

I have no idea what's up with BSD, @jbeich could you take a look?

@Nekotekina
Copy link
Member

Well, clang 11 can be fine for now as minimal requirement. Switching to gcc-10 is more important.

@jbeich
Copy link
Contributor

jbeich commented Apr 28, 2021

@xddxd, apply f6a2b29: libc++ 13 (snapshot) saves it into <__config_site> during build. In future bundled libc++ may need to be built instead of simply extracted.

Example <__config_site> from FreeBSD
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#ifndef _LIBCPP_CONFIG_SITE
#define _LIBCPP_CONFIG_SITE

/* #undef _LIBCPP_ABI_VERSION */
/* #undef _LIBCPP_ABI_UNSTABLE */
/* #undef _LIBCPP_ABI_FORCE_ITANIUM */
/* #undef _LIBCPP_ABI_FORCE_MICROSOFT */
/* #undef _LIBCPP_HIDE_FROM_ABI_PER_TU_BY_DEFAULT */
/* #undef _LIBCPP_HAS_NO_GLOBAL_FILESYSTEM_NAMESPACE */
/* #undef _LIBCPP_HAS_NO_STDIN */
/* #undef _LIBCPP_HAS_NO_STDOUT */
/* #undef _LIBCPP_HAS_NO_THREADS */
/* #undef _LIBCPP_HAS_NO_MONOTONIC_CLOCK */
/* #undef _LIBCPP_HAS_NO_THREAD_UNSAFE_C_FUNCTIONS */
/* #undef _LIBCPP_HAS_MUSL_LIBC */
/* #undef _LIBCPP_HAS_THREAD_API_PTHREAD */
/* #undef _LIBCPP_HAS_THREAD_API_EXTERNAL */
/* #undef _LIBCPP_HAS_THREAD_API_WIN32 */
/* #undef _LIBCPP_HAS_THREAD_LIBRARY_EXTERNAL */
/* #undef _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS */
#define _LIBCPP_HAS_NO_VENDOR_AVAILABILITY_ANNOTATIONS
/* #undef _LIBCPP_NO_VCRUNTIME */
/* #undef _LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION */
/* #undef _LIBCPP_ABI_NAMESPACE */
/* #undef _LIBCPP_HAS_NO_FILESYSTEM_LIBRARY */
/* #undef _LIBCPP_HAS_PARALLEL_ALGORITHMS */
/* #undef _LIBCPP_HAS_NO_RANDOM_DEVICE */
/* #undef _LIBCPP_HAS_NO_LOCALIZATION */



#endif // _LIBCPP_CONFIG_SITE

@sboyd-m
Copy link

sboyd-m commented Apr 28, 2021

Don't forget the BUILDING.md :)

CI/FreeBSD: unbreak build with bundled libc++ 12

Co-authored-by: Jan Beich <jbeich@FreeBSD.org>
@xddxd
Copy link
Contributor Author

xddxd commented Apr 28, 2021

Should be good to go.

@Nekotekina Nekotekina merged commit 64a109d into RPCS3:master Apr 28, 2021
@Blitzwing1
Copy link

On Pop_OS 20.04 every build past this commit no longer start. 0.0.15-12166 works correctly.

rpcs3: error while loading shared libraries: libOpenGL.so.0: cannot open shared object file: No such file or directory.

@hcorion
Copy link
Member

hcorion commented May 1, 2021

Can you open an issue for this @Blitzwing1 ? In the meantime, you can install libopengl to fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration OS: Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants