Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx/gl: Fixes #11062

Merged
merged 6 commits into from
Oct 27, 2021
Merged

rsx/gl: Fixes #11062

merged 6 commits into from
Oct 27, 2021

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 26, 2021 •
edited
Loading

  • Handle pre-byteswapped data (swizzled usually) in the compute-safe path. Fixes stippling/moire pattern when rendering certain effects with the OpenGL backend.
  • Fix DXT texture upload dimensions for mipmapped NPOT textures.
  • Disable shader interpreter if hardware does not meet minimum requirements for it (GL4.3 + ARB_bindless_texture)
  • Fix a UAF bug with OpenGL texture objects due to unexpected invalidate for overlapping blit engine src and dest.

Fixes #7042
Fixes #11024

@kd-11
gl: Fix decoding of wide, swizzled textures
a7952b5 
- Handle pre-byteswapped data (swizzled usually) in the compute-safe path
@kd-11 kd-11 mentioned this pull request Oct 26, 2021
Closed
@kd-11
gl: Disable shader interpreter if hardware does not support bindless …
0feb772 
…textures
@kd-11
gl: Use real image dimensions when decoding compressed textures
79e6d59 
- Image size is already correctly calculated using block dimensions
@kd-11
rsx: Do not reuse/destroy sections that have references held
c861a5c 
- Avoids a situation where blit-dst and blit-src have overlapping ranges. Uploading blit-dst destroys blit-src and vice-versa.
  This is not the end of the world, but blit-src should be kept around until the operation is completed to avoid stale references!
@kd-11 kd-11 changed the title gl: Fix decoding of wide, swizzled textures gl: Fixes Oct 26, 2021
@kd-11 kd-11 changed the title gl: Fixes rsx/gl: Fixes Oct 26, 2021
@gamrXerus gamrXerus mentioned this pull request Oct 26, 2021
Closed
@Megamouse Megamouse added the RSX label Oct 26, 2021
@kd-11 kd-11 merged commit 78bcb0f into RPCS3:master Oct 27, 2021
@eugenecormier
Copy link

I'm on linux here and this build is failing on launch. What I see on the terminal is: execv error: Exec format error
No problem with all previous builds?

@AniLeo
Copy link
Member

AniLeo commented Oct 28, 2021

#11067

@kd-11 kd-11 mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix Render: OpenGL RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shader interpreter error RSX Compilation failed ogl: Class of Heroes 2G [NPUB31541] portraits are glitchy
4 participants
@kd-11 @eugenecormier @AniLeo @Megamouse