[TESTERS NEEDED] rsx: Handle tiled memory

[kd-11]

Addresses #13680

Fixes #6399
Fixes #6609 (partially, that game has another bug)
Fixes #12756

Also fixes many AAA games when run without patches + WCB+RCB because they often do SPU MLAA. This set fixes memory access and removes the honeycomb stippling pattern observed previously.

[MarioSonic2987]

Fixes the honeycomb stippling glitch in Split/Second.

Before:

After:

[TigiHof]

Fixes the honeycomb stippling glitch in Star Wars: The Force Unleashed Demo (NPEB90094).

Before:

After:

However notice the graphical artifact in the bottom right corner.

Log File:
RPCS3.log.gz

I can also provide a RSX capture if required.

[Ordinary205]

Partially fixes NFS The Run when enabling WCB+RCB.

Master:

PR:

Also the RCB seems to have fixed the missing lighting, although they still appear incorrect.

[cas-1092]

Partially fixes artifacting in Blur with RCB.
PR

Master

[Ordinary205]

Fixes disney games such as Cars 3: Driven to Win.

Master:

PR:

RPCS3.log.gz

[Ordinary205]

This also fixes incorrect car reflections on NFS Most Wanted and Hot Pursuit.

Master:

PR:

Altough, the flickering car reflections still exists.

Car.reflections.flicker.mp4

[Linear524]

Holy s#1D !!! I've been waiting many years for this ! :) Thank you KD-11 ! =D
MLAA is finaly fixed for many titles ! And it is almost perfectly fixed, just some minor issues with some horisontal line (looks like overflow somewhere)

[Linear524]

Uncharted 2 is fully playable now and no patches needed :)
Native 720p mode with FSR upscale and with RCB+WCB+RDB+WDB on.

[Linear524]

Uncharted 3 is 99% playable:



And here is that 1% issue with horizontal artifacts:

[Linear524]

Last of Us is 90% playable now without any patches, just Native 720p mode with FSR upscale and with RCB+WCB+RDB+WDB on:

And the other 10% issues = is missing vlolumetric lighting via SPUs, missing smoke and fog via SPUs and those horizontal lines artifacts when there is very bright object in rendered frame (overflow in color buffers?) :

[elad335]

Please test regressions with savestates with this. (in case it does not break it further)

[Ordinary205]

Mountain textures now renders correctly on NFS Rivals when using WCB+RCB.

RPCS3.log.gz

[YuriNator557]

Wasn't a reported issue on GitHub, but graphics in Sniper Elite III are vastly improved (using RWCB+RWDB)

Master (as of 15468)

PR

[scorpion81]

I know this is still a work in progress PR, but I wanted to list some remaining issues after testing Split / Second so far.
Nevertheless this is already a great improvement :)

1. In the game menu, there are still missing explosion and smoke effects.
2. In the car selection menu, there are ghosting issues when the car models are being rotated or moved.
3. Without WCB+RCB, the skybox smearing / ghosting issue still is present, and some environment lighting seems to miss.
4. With WCB + RCB, the skybox smearing and environment lighting is fixed, but ingame fire and smoke effects are missing.
   Side note, without WCB + RCB performance seems also be better by 5 - 10 fps.

I have also tested with WDB + RDB but both didnt seem to have an effect.

Edit: in the menu and ingame too this message appears quite often in the log:
E {RSX [0x0120e60]} RSX: Unimplemented block size in bytes for texture format: 0x0

I suspect this may be related to the missing smoke / explosions in the menu.
Not quite sure what causes it ingame tho.

[Asinin3]

@Linear524 Would be good if you could show a comparison of what was actually fixed in UC2 or write it. And less images that dont show anything. I spent awhile comparing and cant see whats changed compared to master.

@cas-1092 I spent almost an hour with Blur and dont get that issue on master. RCB actually made it worse for me and I was 60fps locked even with accurate xfloat at 400% res scale. Graphics seemed fine on master?

Also having issues getting ingame on Force Unleashed and NFS Rivals, if someone can msg me on our discord server and provide footage that would be helpful.

[Ordinary205]

Here's a full comparison that I've tested on five games.
https://youtu.be/VMPkN_DRfF8
Sorry if this was recorded on 1080p instead of 4K.

[Ordinary205]

I forgot to mention that this causes a MLAA regression on few frostbite games. Which appears yellow for some reason.

But if I disable the MLAA on NFS Rivals patches, the yellow corrupted screen is gone.

[Linear524]

@Asinin3
Okay. I will try to describe = UC2 was messed up before, when you move camera in front of the flashlight - there was broken MLAA artifacts, and very bright areas was giving the same MLAA artifacts. Now it is fixed with this PR. Even main menu artifacts is fixed by the way. And working MLAA gives us more antialiased edges on the most of rendered geometry.
(NaughtyDog doesn't use MLAA on every geometry layer, just partially on more significant objects)

[elad335]

An image is worth a thousand words.

[Ordinary205]

Here's a comparison for Star Wars: The Force Unleashed.
https://drive.google.com/file/d/164PGETpFuLgc7V53zq0qVAjxn9q7vVzZ/view?usp=sharing

[jenci8888]

NFS Hot Pursuit 2010 is fixed reflection issue (glossy paint and glass)

Master:

PR:

[TryTwo]

Fixes The Witch and the Hundred Knight honeycomb stippling #7041

[legend800]

@TigiHof That gfx artifact can be fixed with SPU Float Accurate.:

So settings for this game are: WCB + RCB(general gfx), Accurate SPU DMA(boot fix), SPU Float Accurate(corrupted border gfx)

The game appears to be perfect other than an issue where all the main/pause menu text gets corrupted on the 2nd load. Tried every setting possible but couldn't find fix. Present on Master as well.

[TigiHof]

@TigiHof That gfx artifact can be fixed with SPU Float Accurate.

Unfortunately that does not work for me. The artifact is still present. But thanks, anyway!

[kd-11]

@TigiHof That gfx artifact can be fixed with SPU Float Accurate.

Unfortunately that does not work for me. The artifact is still present. But thanks, anyway!

I cannot reproduce the artifact. Maybe it's caused by upscaling in this case? Missing pixels in the bottom-right is a known gotcha with the tiling setup because the hardware overscans the memory by 48px at 720p res. However, that is already accounted for.

[Darkhost1999]

Turing gfx gtx 1660 super with default resolution
RPCS3.log
Accurate rsx reservation access resolving freezes for me.
Accurate xfloat doesn't change the image
Everything is clean installed onto this PR all caches unique, all update files, everything as if I started using RPCS3 today

[TigiHof]

I cannot reproduce the artifact. Maybe it's caused by upscaling in this case? Missing pixels in the bottom-right is a known gotcha with the tiling setup because the hardware overscans the memory by 48px at 720p res. However, that is already accounted for.

No, no upscaling involved. Here is a RSX capture:
https://drive.google.com/file/d/1NLc1NYE5HOg40CsEi4nNi85WRzjG6q3C/view?usp=sharing

[kd-11]

I think I'll just try and figure out why rivals broke and commit this. There is a lot of work left to do afterward such as OpenGL support which is completely missing at the moment.

[kd-11]

After thinking about it and seeing all the problems I think an option makes more sense than trying to fix everything in one PR.

[kd-11]

If any problems are observed, please report them at #14682 so I can investigate.

[alanjsebas]

Can someone share their build of the Windows version with the fix installed?

[Jonathan44062]

@alanjsebas The PR has already been merged in the master, update the emulator and activate this new option in Advanced tab

[alanjsebas]

Somehow I didn't notice that.

Incredibly sorry, and thanks.