Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new vignette about packaging C++ libraries (closes #1077) #1078

Merged
merged 7 commits into from
May 1, 2020

Conversation

eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Apr 30, 2020

As discussed in #1077, we have a new vignette candidate. And there seems to be some support for including it.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@codecov-io
Copy link

Codecov Report

Merging #1078 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          64       64           
  Lines        2787     2787           
=======================================
  Hits         2663     2663           
  Misses        124      124           

@eddelbuettel
Copy link
Member Author

Will go slightly off usual schedule and merge this -- as it leaves inst/include, src/, R/ and inst/tinytest alone there should really be no surprise from this on the behavior side.

@eddelbuettel eddelbuettel merged commit 95d0854 into master May 1, 2020
@eddelbuettel eddelbuettel deleted the feature/library_vignette branch May 1, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants