String and (const_)string_proxy are now comparable #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Looks good -- thanks! |
|
Great, with this and the parallel email discussion this is good to go. |
eddelbuettel
added a commit
that referenced
this pull request
Sep 7, 2015
String and (const_)string_proxy are now comparable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an open PR for this that got auto-closed when I reorganized my repo. This is a feature requested in the discussion of #191.
In the previous PR discussion @thirdwing mentioned that due to #251 we ought not to implement
>, <, >=, <=operators so they are not present.Unit tests are present and pass.
Sorry for the confusion with the multiple PRs.