Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImproved exception infrastructure #676
Conversation
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
- Coverage 92.91% 92.88% -0.03%
==========================================
Files 65 65
Lines 3302 3303 +1
==========================================
Hits 3068 3068
- Misses 234 235 +1
Continue to review full report at Codecov.
|
|
Looks good to me at first glance. Reverse depend check running too. |
|
It seems to make some noise in other project though ... when |
This is PR 2 of 3.
Contained within this PR is the necessary upgrade to the exception infrastructure to proceed with improving internal exception messages.
The third PR aims to provide the improved internal exception messages based on the proposal table in #184.
(The first PR was the upstream refresh of the tinyformat library.)
Changes:
Rcpp::stop,Rcpp::warning, andRCPP_ADVANCED_EXCEPTION_CLASSRcpp::stopandRcpp::warningfunctions fromexception.hand moved them into C++98 exception headerRCPP_EXCEPTION_CLASSmacro to have a default ctor that returns a default constructed string to allow for promotion without breaking present use.no_such_slotandnot_a_closureto useRCPP_EXCEPTION_CLASSfromRCPP_SIMPLE_EXCEPTION_CLASS.index_out_of_boundsandnot_compatibleto useRCPP_ADVANCED_EXCEPTION_CLASS.no_such_fieldandreference_creation_classfor potential removal.