New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use public R APIs for new_env #785

Merged
merged 3 commits into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@kevinushey
Contributor

kevinushey commented Dec 5, 2017

Closes #771. We use Rcpp::Function + new.env() instead of an (unfortunately) unexported R API for constructing environments.

@@ -44,6 +44,15 @@ Environment_Impl<StoragePolicy>::Environment_Impl( int pos ){
Storage::set__(env) ;
}
inline Environment new_env(int size = 29) {
Function newEnv("new.env");

This comment has been minimized.

@eddelbuettel

eddelbuettel Dec 5, 2017

Member

Should we be fancy and memoise / keep a once init'ed Function ? Probably not worth it.

This comment has been minimized.

@kevinushey

kevinushey Dec 5, 2017

Contributor

We could do that (just make it a static object so it's only initialized once on first call). Certainly doesn't hurt but agree we don't gain much.

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Dec 6, 2017

I think I'll just squash merge this later and then run a new rev dep. Unless you want to rebase...

@kevinushey

This comment has been minimized.

Contributor

kevinushey commented Dec 6, 2017

Squash merge sounds good to me.

@eddelbuettel eddelbuettel merged commit 921e7d6 into master Dec 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the bugfix/new-env-public-api branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment