use public R APIs for new_env #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
reviewed
Dec 5, 2017
| @@ -44,6 +44,15 @@ Environment_Impl<StoragePolicy>::Environment_Impl( int pos ){ | |||
| Storage::set__(env) ; | |||
| } | |||
|
|
|||
| inline Environment new_env(int size = 29) { | |||
| Function newEnv("new.env"); | |||
There was a problem hiding this comment.
Should we be fancy and memoise / keep a once init'ed Function ? Probably not worth it.
There was a problem hiding this comment.
We could do that (just make it a static object so it's only initialized once on first call). Certainly doesn't hurt but agree we don't gain much.
|
I think I'll just squash merge this later and then run a new rev dep. Unless you want to rebase... |
|
Squash merge sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771. We use
Rcpp::Function+new.env()instead of an (unfortunately) unexported R API for constructing environments.