-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alternate way to grab 'long long' type #829
Conversation
For context, the Rtools toolchain has a
which I'm making use of in choosing the |
This also makes me think there might be a chance that we could sneak in |
That is a bit of a "riskier" approach as it touches the old part. Oh I see you just mod'ed that. |
I think this should be ready of merge. Just to summarize the changes:
I think this effectively lets us use If we find out this doesn't work as expected or we end up with warnings on some other platform we can of course back it out, but thus far things look good on my Windows VM, macOS machine and Ubuntu 16.04 VM (with gcc-5). |
This is good stuff, and I had it go over a rev.dep run as well. |
Thanks! |
Shall we call it a day and ship this now as Rcpp 0.12.16? |
Sounds good to me! |
This PR is another attempt to grab 64-bit integer types in C++98 mode in a way that won't trigger pedantic compiler warnings. Fortunately, seems to work on my Windows box using the latest Rtools toolchain.