Matrix(no_init())

[romainfrancois]

The constructor does not set nrows. https://github.com/RcppCore/Rcpp/blob/master/inst/include/Rcpp/vector/Matrix.h#L92

    explicit Matrix( const no_init_matrix& obj) {
        VECTOR::set__( Rf_allocMatrix( RTYPE, obj.nrow(), obj.ncol() ) );
    }

I have a patch that I'll submit as a pull request.

[romainfrancois]

Is a thumbs up reaction enough green light to send the pull request ?

[kevinushey]

Do you recall why we maintain nrows as a variable separate to what's already defined as part of the dims attribute? Just for efficiency in lookup?

[romainfrancois]

IIRC this was about performance, i.e. implementing the ( operator so that we can cheaply go from i, j to the underlying vector index.

[eddelbuettel]

I always liked how Armadillo exports this as read-only variables rather than calls: http://arma.sourceforge.net/docs.html#attributes

Ours did come earlier, and I think it was indeed the performance / easy of use consideration.

[kevinushey]

Sounds good. Either way this definitely warrants a patch; thanks for taking the time to prepare one.

[eddelbuettel]

And making sure it passes tests :)