add system TBB autodetection on Unix #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinushey Any chance of merging this any time soon? |
kevinushey
reviewed
Jan 31, 2023
| define(TBB_LIB_AUTO = "", TBB_INC_AUTO = "") | ||
| if (.Platform$OS.type == "unix") { | ||
| tbbLib <- Sys.glob(c( | ||
| "/usr/*/libtbb.so", |
There was a problem hiding this comment.
If we wanted to support common macOS configurations (on arm64 machines) we could check /opt/homebrew/lib and /opt/homebrew/include/tbb.
|
(Sorry it took me so long to review this; for some reason I must've missed it a long time ago after you prepared the PR.) |
|
No problem, thanks! |
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple glob-based autodetection. Not sure if these cases cover macOS though. Could you check, please?
Closes #163.