-
Notifications
You must be signed in to change notification settings - Fork 97
Review Request A. K. Diem #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@akdiem Thanks for your submission, we'll assign an editor soon. Do you have a link to an open-access version of the original article ? |
Dear @ReScience/associate-editors Can someone edit this submission (domain is Biology / Neurovascular coupling)? |
@rougier The original authors have a pdf on their website |
Thanks, a link is perfect ! |
Is it acceptable to make small changes to the manuscript at this point? I have just realised that I forgot to add a detail for implementing one of the equations, which I only got to know about by contacting the original authors. |
No problem, you can |
@akdiem Just to let you know I did not forget you, an editor will be assigned soon hopefully. |
@benoit-girard Can you edit this submission ? |
Yes |
@ChristophMetzner Do you think you can review this submission? |
@benoit-girard At first glance it seems a little bit out of my comfort zone. I will have a closer look this evening and reply tomorrow the latest. |
@benoit-girard Had a closer look and, although I am not an expert on the topic, I feel confident to review. |
@ChristophMetzner OK, great, thank you. |
A second reviewer is expected to join soon. Thanks for your patience. |
@benoit-girard Ok, thanks for the update! |
I just modified eq 23. |
@ChristophMetzner @benoit-girard @akdiem Because of the change in the equation, the result plots that the new codes produce are different than earlier, but you still have the old figures in your manuscript. Mostly the results vary just a bit, but new Figure 6b plotted from the new code is very different compared to the earlier version. |
It seems that the best set of changes was to leave eqs 5 and 23 as in the original publication, but change the definition of J_trpv to positive sign and J_Ca negative. |
@ChristophMetzner @benoit-girard @akdiem The signs in your version of Equation 23 in the manuscript do not match the signs in your code. Please correct in the manuscript. |
Thanks for carefully checking, there's always the one spot. |
@ChristophMetzner @benoit-girard @akdiem Thanks for making the last modification! The signs were already confusing in the original manuscript, but if you plan still to make errata with the original authors, I would kindly suggest to pay attention to the signs that they are given biologically correct. I have now accepted the submission. Congratulations! |
@ChristophMetzner @akdiem |
@benoit-girard @akdiem No, this issue has been resolved. |
@ChristophMetzner are you now ready to make a final decision [accept/reject] on this paper? |
@benoit-girard @akdiem My final decision is to accept the paper. |
@akdiem Congratulations, I hereby accept the submission for publication! |
@akdiem could you provide a list of keywords? |
Thank you for accepting my submission! Please use these keywords: neurovascular modelling, neurovascular unit, chemical signalling, astrocytes, neuroscience |
EDITOR This submission has been accepted for publication, and has been published at |
@benoit-girard Don't forget to update Volume 3 - Issue 1 file as well |
@rougier I did and just submitted the corresponding PR (hopefuly). |
When the last step of the "publication process" states "Close the PR without merging", it refers to the PR initiated by the author in ReScience-submission? Meaning, in this case, the PR #33 where this comment appears? |
Exactly! Just push the "close pull request" button below. |
I cannot see your PR. Do you see it on your side ? Do you have a pointer ? |
DIEM
Dear @ReScience/editors,
I request a review for the following replication:
Original article
Title: A bidirectional model for communication in the neurovascular unit
Author(s): Witthoft A, Karniadakis GE
Journal (or Conference): Journal of Theoretical Biology
Year: 2012
DOI: https://doi.org/10.1016/j.jtbi.2012.07.014
PDF: http://www.sciencedirect.com/science/article/pii/S0022519312003487
Replication
Author(s): Diem AK
Repository: https://github.com/akdiem/ReScience-submission/tree/Diem-2017
PDF: https://github.com/akdiem/ReScience-submission/blob/Diem-2017/article/Diem-2017.pdf
Keywords: neurovascular unit, neurovascular signalling, neurovascular coupling, astrocyte signalling
Language: Python 3.5.3
Domain: Neurovascular coupling
Results
I believe the original results have been almost fully reproduced as explained in the accompanying article.
EDITOR
June 28, 2017
July 4, 2017
July 7, 2017
September 6, 2017
August 31, 2017
September 6, 2017