Skip to content

Review Request A. K. Diem #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 102 commits into from
Closed

Conversation

alexdiem
Copy link

@alexdiem alexdiem commented Jun 20, 2017

DIEM

Dear @ReScience/editors,

I request a review for the following replication:

Original article

Title: A bidirectional model for communication in the neurovascular unit
Author(s): Witthoft A, Karniadakis GE
Journal (or Conference): Journal of Theoretical Biology
Year: 2012
DOI: https://doi.org/10.1016/j.jtbi.2012.07.014
PDF: http://www.sciencedirect.com/science/article/pii/S0022519312003487

Replication

Author(s): Diem AK
Repository: https://github.com/akdiem/ReScience-submission/tree/Diem-2017
PDF: https://github.com/akdiem/ReScience-submission/blob/Diem-2017/article/Diem-2017.pdf
Keywords: neurovascular unit, neurovascular signalling, neurovascular coupling, astrocyte signalling
Language: Python 3.5.3
Domain: Neurovascular coupling

Results

  • Article has been fully replicated
  • Article has been partially replicated
  • Article has not been replicated

I believe the original results have been almost fully reproduced as explained in the accompanying article.


EDITOR

  • Editor acknowledgment June 28, 2017
  • Reviewer 1 started (@ChristophMetzner) July 4, 2017
  • Reviewer 2 (@TiinaManninen July 7, 2017
  • Review 1 decision [accept] September 6, 2017
  • Review 2 decision [accept] August 31, 2017
  • Editor decision [accept] September 6, 2017

@rougier
Copy link
Member

rougier commented Jun 20, 2017

@akdiem Thanks for your submission, we'll assign an editor soon. Do you have a link to an open-access version of the original article ?

@rougier
Copy link
Member

rougier commented Jun 20, 2017

Dear @ReScience/associate-editors

Can someone edit this submission (domain is Biology / Neurovascular coupling)?

@rougier rougier added the Python label Jun 20, 2017
@alexdiem
Copy link
Author

@rougier The original authors have a pdf on their website
https://www.brown.edu/research/projects/crunch/sites/brown.edu.research.projects.crunch/files/uploads/Alix_bidirectional.pdf I didn't upload it into my repository because I did not want to infringe on the journal copyright.

@rougier
Copy link
Member

rougier commented Jun 20, 2017

Thanks, a link is perfect !

@alexdiem
Copy link
Author

Is it acceptable to make small changes to the manuscript at this point? I have just realised that I forgot to add a detail for implementing one of the equations, which I only got to know about by contacting the original authors.

@rougier
Copy link
Member

rougier commented Jun 22, 2017

No problem, you can

@rougier
Copy link
Member

rougier commented Jun 23, 2017

@akdiem Just to let you know I did not forget you, an editor will be assigned soon hopefully.

@rougier
Copy link
Member

rougier commented Jun 27, 2017

@benoit-girard Can you edit this submission ?

@benoit-girard
Copy link

Yes

@benoit-girard
Copy link

@ChristophMetzner Do you think you can review this submission?

@ChristophMetzner
Copy link

@benoit-girard At first glance it seems a little bit out of my comfort zone. I will have a closer look this evening and reply tomorrow the latest.

@ChristophMetzner
Copy link

@benoit-girard Had a closer look and, although I am not an expert on the topic, I feel confident to review.

@benoit-girard
Copy link

@ChristophMetzner OK, great, thank you.
It is difficult to find someone fully comfortable with the topic, given our current set of reviewers. I have been contacting potential reviewers by mail, without much success up to now. I am waiting for answers, that's why we will have to wait a bit before we have a second reviewer.

@benoit-girard
Copy link

A second reviewer is expected to join soon. Thanks for your patience.

@alexdiem
Copy link
Author

alexdiem commented Jul 7, 2017

@benoit-girard Ok, thanks for the update!

@alexdiem
Copy link
Author

I just modified eq 23.

@TiinaManninen
Copy link

@ChristophMetzner @benoit-girard

@akdiem Because of the change in the equation, the result plots that the new codes produce are different than earlier, but you still have the old figures in your manuscript. Mostly the results vary just a bit, but new Figure 6b plotted from the new code is very different compared to the earlier version.

@alexdiem
Copy link
Author

It seems that the best set of changes was to leave eqs 5 and 23 as in the original publication, but change the definition of J_trpv to positive sign and J_Ca negative.

@TiinaManninen
Copy link

@ChristophMetzner @benoit-girard

@akdiem The signs in your version of Equation 23 in the manuscript do not match the signs in your code. Please correct in the manuscript.

@alexdiem
Copy link
Author

Thanks for carefully checking, there's always the one spot.

@TiinaManninen
Copy link

@ChristophMetzner @benoit-girard

@akdiem Thanks for making the last modification! The signs were already confusing in the original manuscript, but if you plan still to make errata with the original authors, I would kindly suggest to pay attention to the signs that they are given biologically correct. I have now accepted the submission. Congratulations!

@benoit-girard
Copy link

@ChristophMetzner @akdiem
If I correctly followed the discussion, the last point standing concerns the signs of J_BK and J_KIR currents?
@ChristophMetzner : do you still have a concern about that?

@ChristophMetzner
Copy link

@benoit-girard @akdiem No, this issue has been resolved.

@benoit-girard
Copy link

@ChristophMetzner are you now ready to make a final decision [accept/reject] on this paper?

@ChristophMetzner
Copy link

@benoit-girard @akdiem My final decision is to accept the paper.

@benoit-girard
Copy link

@akdiem Congratulations, I hereby accept the submission for publication!
@ChristophMetzner , @TiinaManninen thank you for your reviews!

@benoit-girard
Copy link

@akdiem could you provide a list of keywords?

@alexdiem
Copy link
Author

alexdiem commented Sep 6, 2017

Thank you for accepting my submission! Please use these keywords: neurovascular modelling, neurovascular unit, chemical signalling, astrocytes, neuroscience

@ReScience ReScience locked and limited conversation to collaborators Sep 7, 2017
@benoit-girard
Copy link

benoit-girard commented Sep 13, 2017

EDITOR

This submission has been accepted for publication, and has been published at
http://rescience.github.io/read/

DOI

@rougier
Copy link
Member

rougier commented Sep 18, 2017

@benoit-girard Don't forget to update Volume 3 - Issue 1 file as well

@benoit-girard
Copy link

@rougier I did and just submitted the corresponding PR (hopefuly).

@benoit-girard
Copy link

When the last step of the "publication process" states "Close the PR without merging", it refers to the PR initiated by the author in ReScience-submission? Meaning, in this case, the PR #33 where this comment appears?

@khinsen
Copy link
Contributor

khinsen commented Sep 20, 2017

Exactly! Just push the "close pull request" button below.

@rougier
Copy link
Member

rougier commented Sep 20, 2017

I cannot see your PR. Do you see it on your side ? Do you have a pointer ?

@benoit-girard
Copy link

@khinsen Will close it now
@rougier Finally managed to do the PR (sorry for the delay)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants