-
Notifications
You must be signed in to change notification settings - Fork 97
Review Request: Bavard and Théro #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your submission. An editor will be assigned soon. |
@oliviaguest Can you edit this submission ? |
@rougier I can do it after the 20th of this month, is that too late? |
@oliviaguest Yes |
@heloisethero Can you also add a link to the PDF? There was a link but it was pointing to the article that seem to be stored on GitHub. Since it is a copyrighted article you cannot add it to GitHub. BEst would be to have an open access version. Else, you can add the official entry from Biol. Cybernetics. |
@rougier I have now added a link to my repository at the right place, sorry about that. I have also added a link to the first author's ResearchGate article pdf. The figures in it are identical to the ones published in Biol. Cybernetics, although the formatting is different. I have also added to the official entry from Biol. Cybernetics just in case. |
@heloisethero Perfect. As you may have read in the thread @oliviaguest will handling your submission after February 20th. If this is a problem just tell us, we'll try to find another editor. |
@rougier and @oliviaguest, there is no problem, Sophie (@sophiebavard) and I accept your decision. |
@oliviaguest Reminder |
@benoit-girard @MehdiKhamassi @neuronalX any of you have time to review this? |
@oliviaguest Yes, I can review it. |
@oliviaguest Technically, I can do it. |
@oliviaguest Thank you for the invitation! I am already late with two other reviews. So I cannot currently. Best wishes |
@MehdiKhamassi @benoit-girard @neuronalX Thank you all for the speedy replies! 😄 @rougier What do you think/what are the rules vis-à-vis the potential conflict? |
I meant to write to the authors. The python code generating all the figures are on my github repo. They were mislead because they look at Matt Van Der Meer lab repo and could not find the code. I thought the link to the repo was in the original article. |
I am going to alert also Matt. https://github.com/rcaze/13_02CaVa |
@rcaze we are sorry for this mistake. As your article was really influential in our research team, we have tried on several occasions to replicate parts of it. We have been looking for your code, but never found it. Therefore we have recoded everything from scratch. |
@heloisethero The fact you can replicate the original code using the published papers without looking at the original code is extremely important. It means the specification is actually complete given the journal articles and other writing. This is a massive boon to the original authors' work, their framework, etc. For more see, e.g., Cooper, R. P. & Guest, O. (2014). Implementations are not specifications: specification, replication and experimentation in computational cognitive modeling. Cognitive Systems Research. doi: 10.1016/j.cogsys.2013.05.001. |
@heloisethero I agree with @oliviaguest. I am honoured by this attention and think that the independent reproduction gives strength to this result. Notably, the original code lacks a documentation. One member of our lab (@frct) is currently working on this topic and could give a serious review of the work. If the editors wish I can also review the paper even if I think that I am a little biased :). |
Yes, it is perfectly fine to replicate the code even if the original code is available as long as your replication is not a simple translation from one language to another and is not a copy. So this submission is fine for me. |
@oliviaguest hello, @sophiebavard and I were wondering if you have chosen the second reviewer? |
@heloisethero: As soon as @rougier tells me if there's a conflict (see my question above), I'll act accordingly. Understandably, these things can take time. |
Fig 2 is perfect as soon as these "" are removed... |
@benoit-girard you are right, thank you. Sorry for that, I have corrected it :) |
I am now satisfied with the paper. |
@neuronalX Did you have any chance to check our simulations? :) |
@oliviaguest @neuronalX Gentle reminder. |
No, sorry, didn't find the time so far to have a complete look at all the comments since my review. |
@neuronalX Can you give back your comments by the end of the week please. |
Thank you for the changes you made.
Yes, it works fine for me now. Concerning the Figure 4 A, maybe you could just add a sentence saying that some similar figure could be obtained by dividing the number of simulations by 10 for instance (so this info does not stay in the review only). @oliviaguest @rougier I recommend acceptation. |
Excellent! @heloisethero do you what to address the small comment above on your figure 4 A? |
We added one sentence on the results section according to one of the reviewers' advice.
We added one sentence on the results section according to one of the reviewers' advice.
@neuronalX thank you for your comment. We added this sentence at the end of the results section :
@oliviaguest let us know if we need to do anything else? |
@heloisethero I cannot see anything else that needs doing from your end — so I'll reply on this thread when I am done publishing this, assigning a DOI, etc. |
This submission has been accepted for publication! It should appear soon on the journal website (here) with DOI: |
AUTHOR
Dear @ReScience/editors,
I request a review for the following replication:
Original article
Title: Adaptive properties of differential learning rates for positive and negative outcomes
Author(s): Cazé, R. D., & van der Meer, M. A.
Journal (or Conference): Biological cybernetics
Year: 2013
DOI: 10.1007/s00422-013-0571-5
PDF: Caze&vanderMeer2013.pdf
https://link.springer.com/article/10.1007/s00422-013-0571-5
Replication
Author(s): Bavard, Sophie & Théro, Héloïse
Repository: BAVARD-THERO-2018
PDF: Bavard-Thero-2018.pdf
Keywords: Reinforcement learning, Q-learning, adaptive learning rates
Language: Python
Domain: Computational Neuroscience
Results
Potential reviewers
Benoît Girard
Mehdi Khamassi
Xavier Hinaut
EDITOR
February 20, 2018
)February 21, 2018
)March 2, 2018
)May 29, 2018
]June 11, 2018
]June 14, 2018
]