Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caron, Lessard, Wu, Poisot #50

Closed
wants to merge 181 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@tpoisot
Copy link

tpoisot commented May 14, 2018

AUTHOR

Dear @ReScience/editors,

I request a review for the following replication:

Original article

Title: Insect natural enemies as regulating factors
Author(s): M.P. Hassell
Journal (or Conference): Journal of Animal Ecology
Year: 1985
DOI: https://doi.org/10.2307/4641
PDF:

Replication

Author(s): @DominiqueCaron @vincelessard @QileWu @tpoisot
Repository: https://github.com/BIO6032/2018_replication_hassell_1985
PDF: https://github.com/BIO6032/2018_replication_hassell_1985/blob/master/article/Caron-Lessard-Wu-Poisot-2018.pdf
Keywords: population dynamics, ecology, stochastic models
Language: Julia
Domain: ecology

Results

  • Article has been fully replicated
  • Article has been partially replicated
  • Article has not been replicated

Potential reviewers


EDITOR

  • Editor acknowledgment (@pdebuyl 9 June 2018)
  • Reviewer 1 (@ChrisRackauckas 13 June 2018)
  • Reviewer 2 (@jsta 14 June 2018)
  • Review 1 decision: accept 12 October 2018
  • Review 2 decision: accept 20 February 2019
  • Editor decision [accept/reject] 13 March 2019

tpoisot and others added some commits Mar 1, 2018

Merge pull request #7 from BIO6032/QileWu-patch-1
function2 and function4
Update functions.jl
add function 6 + change function 5 name
Update functions.jl
Fix function k-value + add column in simulation

Not sure how we are suppose to compute S (function kvalue)
Update functions.jl
Add missing documentation for the 2 first functions
@pdebuyl

This comment has been minimized.

Copy link
Member

pdebuyl commented Feb 20, 2019

@ChrisRackauckas Thanks for the prompt reading.

@tpoisot please update the figures, I'll check the pdf a final time then. You are early w.r.t. your announced date of March 10, no patience was needed :-)

@tpoisot

This comment has been minimized.

Copy link
Author

tpoisot commented Feb 21, 2019

@pdebuyl Figures updated, and I've built the PDF

@pdebuyl

This comment has been minimized.

Copy link
Member

pdebuyl commented Feb 26, 2019

Hi @tpoisot @DominiqueCaron thanks for the update.

See BIO6032#30

If you are ok with the changes, I'll follow with the publication. See this throwaway branch https://github.com/pdebuyl/ReScience-submission/tree/caron_2018_edit_with_pdf for a compiled pdf. I'll also have to get rid of the binary pandoc-crossref from the repo...

I could run the code with Julia 1.0.3 (the pdf has these figures) with only a few warnings

This package has been renamed to StatsPlots.
The name StatPlots has been deprecated.

Please run

`]rm StatPlots`
`]add StatsPlots`

Failure to update will mean that you do not receive new developments.

┌ Warning: seriestype density has been moved to StatsPlots.  To use: `Pkg.add("StatsPlots"); using StatsPlots`
└ @ Plots ~/.julia/packages/Plots/UQI78/src/args.jl:1054

(last warning repeated 11 more times).

@pdebuyl

This comment has been minimized.

Copy link
Member

pdebuyl commented Feb 27, 2019

Woops, I also forgot to request the DOIs for all references.

@DominiqueCaron

This comment has been minimized.

Copy link

DominiqueCaron commented Feb 27, 2019

I added most DOIs.
For books, I added the ISBN. For Thompson (1924), I did not find any DOI...

I will let @tpoisot look at it, merge it and update the pdf.

DominiqueCaron and others added some commits Feb 27, 2019

@tpoisot

This comment has been minimized.

Copy link
Author

tpoisot commented Mar 12, 2019

@pdebuyl all done (I think)

@pdebuyl

This comment has been minimized.

Copy link
Member

pdebuyl commented Mar 13, 2019

Hi @DominiqueCaron @tpoisot thank you, I'll publish this shortly.

@rougier

This comment has been minimized.

Copy link
Member

rougier commented Mar 18, 2019

Gentle reminder

@ReScience ReScience locked and limited conversation to collaborators Mar 19, 2019

@pdebuyl

This comment has been minimized.

Copy link
Member

pdebuyl commented Mar 19, 2019

Hi @DominiqueCaron @tpoisot I need the ORCID of everyone for the Zenodo archive. I found the one of Timothée Poisot, I would like the three others.

@pdebuyl

This comment has been minimized.

Copy link
Member

pdebuyl commented Mar 20, 2019

I could get by without the ORCID.

This submission has been accepted for publication, and has been published with the DOI DOI

@pdebuyl

This comment has been minimized.

Copy link
Member

pdebuyl commented Mar 20, 2019

Hi folks, the paper is online and I am just waiting for the toc of the journal to be updated.

@rougier @khinsen I hereby "Inform the editors-in-chief about the new publication".

@pdebuyl pdebuyl closed this Mar 20, 2019

@rougier

This comment has been minimized.

Copy link
Member

rougier commented Mar 20, 2019

Thanks. Can you also try to tell the journal editor-in-chief and authors of the original article that it has been replicated ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.