fix(Reddit): Pin Reddit to 2024.17.0 for HideAdsPatch #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascopes
force-pushed
the
bugfix/GH-3099-pin
branch
from
fec5817 to
09b42d7
Compare
ascopes
commented
May 19, 2024
| // Constrained to last working version (2024.17.0) until https://github.com/iBotPeaches/Apktool/issues/3534 | ||
| // is addressed which is causing crashes during patching. | ||
| // See https://github.com/ReVanced/revanced-patches/issues/3099. | ||
| compatiblePackages = [CompatiblePackage("com.reddit.frontpage", ["2024.17.0"])] |
There was a problem hiding this comment.
Kept this in so it is clear that if anything depends on this in the future that it needs to have this constraint.
Assuming the dependency graph does not resolve these requirements recursively transitively given previous PR feedback?
There was a problem hiding this comment.
The annotation should be removed and instead a comment can be kept. Patcher does not handle this annotation field but the application that runs the patcher.
cyberboh
reviewed
May 19, 2024
src/main/kotlin/app/revanced/patches/reddit/ad/general/HideAdsPatch.kt
Outdated
Show resolved
Hide resolved
ascopes
force-pushed
the
bugfix/GH-3099-pin
branch
from
09b42d7 to
4b7a119
Compare
oSumAtrIX
reviewed
May 21, 2024
src/main/kotlin/app/revanced/patches/reddit/ad/banner/HideBannerPatch.kt
Outdated
Show resolved
Hide resolved
ascopes
force-pushed
the
bugfix/GH-3099-pin
branch
from
4b7a119 to
4e19837
Compare
oSumAtrIX
approved these changes
May 30, 2024
oSumAtrIX
reviewed
May 30, 2024
src/main/kotlin/app/revanced/patches/reddit/ad/general/HideAdsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
approved these changes
May 30, 2024
|
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
revanced-bot
pushed a commit
that referenced
this pull request
May 30, 2024
## [4.8.3-dev.3](v4.8.3-dev.2...v4.8.3-dev.3) (2024-05-30) ### Bug Fixes * **Reddit - Hide ads:** Constrain to last working version 2024.17.0 ([#3192](#3192)) ([4fb3456](4fb3456))
revanced-bot
pushed a commit
that referenced
this pull request
May 31, 2024
## [4.8.3](v4.8.2...v4.8.3) (2024-05-31) ### Bug Fixes * **3rd-party Reddit apps:** Spoof user agent to work around Reddit API issues ([#3253](#3253)) ([495e6d6](495e6d6)) * **Reddit - Hide ads:** Constrain to last working version 2024.17.0 ([#3192](#3192)) ([4fb3456](4fb3456)) * **YouTube - Spoof client:** Clarify that only enter/exit fullscreen gesture does not work with Android VR spoof ([#3243](#3243)) ([06d8f55](06d8f55)) * **YouTube - Spoof client:** Improve Android spoofing ([#3230](#3230)) ([b688923](b688923))
E85Addict
pushed a commit
to E85Addict/revanced-patches
that referenced
this pull request
May 31, 2024
## [4.8.3](v4.8.2...v4.8.3) (2024-05-31) ### Bug Fixes * **3rd-party Reddit apps:** Spoof user agent to work around Reddit API issues ([ReVanced#3253](https://github.com/E85Addict/revanced-patches/issues/3253)) ([495e6d6](495e6d6)) * **Reddit - Hide ads:** Constrain to last working version 2024.17.0 ([ReVanced#3192](https://github.com/E85Addict/revanced-patches/issues/3192)) ([4fb3456](4fb3456)) * **YouTube - Spoof client:** Clarify that only enter/exit fullscreen gesture does not work with Android VR spoof ([ReVanced#3243](https://github.com/E85Addict/revanced-patches/issues/3243)) ([06d8f55](06d8f55)) * **YouTube - Spoof client:** Improve Android spoofing ([ReVanced#3230](https://github.com/E85Addict/revanced-patches/issues/3230)) ([b688923](b688923)) ### Performance Improvements * Personal Logo && Add upstream sync ([929bf2b](929bf2b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #3099 is fixable and addressed, this limits the version of Reddit that can be
used to 2024.0.17 which is the last known working version.
Reopened this from #3156 as the repo was accidentally closed due to an error on my side cleaning up unused forks on my account.
Added feedback from that PR to fix versions and apply the constraint to dependent patches that are named.