Skip to content

Errors management improvement #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2019
Merged

Errors management improvement #203

merged 2 commits into from
Jun 7, 2019

Conversation

teivah
Copy link
Member

@teivah teivah commented Jun 7, 2019

  • Refactoring of some existing errors
  • Use of pkg/errors

@teivah teivah added enhancement Enhancement. version 2 RxGo v2. labels Jun 7, 2019
@teivah teivah added this to the version 2 milestone Jun 7, 2019
@coveralls
Copy link

coveralls commented Jun 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 401

  • 32 of 41 (78.05%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 84.658%
Changes Missing Coverage Covered Lines Changed/Added Lines %
iterator.go 3 4 75.0%
observable.go 26 27 96.3%
observablecreate.go 2 3 66.67%
errors.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
errors.go 1 0.0%
Totals Coverage Status
Change from base Build 379: 0.1%
Covered Lines: 1970
Relevant Lines: 2327
💛 - Coveralls

@teivah teivah merged commit 7ab4f92 into v2 Jun 7, 2019
@teivah teivah deleted the errors branch June 7, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement. version 2 RxGo v2.
Projects
None yet
Milestone
version 2
Development

Successfully merging this pull request may close these issues.
2 participants
@teivah @coveralls