Skip to content

Use a channel instead of a mutex for Observer and SingleObserver #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2019
Merged

Use a channel instead of a mutex for Observer and SingleObserver #204

merged 3 commits into from
Jun 7, 2019

Conversation

teivah
Copy link
Member

@teivah teivah commented Jun 7, 2019

@teivah teivah added enhancement Enhancement. version 2 RxGo v2. labels Jun 7, 2019
@teivah teivah added this to the version 2 milestone Jun 7, 2019
@teivah teivah mentioned this pull request Jun 7, 2019
Closed
@teivah teivah merged commit 51c123b into v2 Jun 7, 2019
@teivah teivah deleted the chan-disposed2 branch June 7, 2019 22:28
@coveralls
Copy link

coveralls commented Jun 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 406

  • 32 of 33 (96.97%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 84.742%
Changes Missing Coverage Covered Lines Changed/Added Lines %
singleobserver.go 19 20 95.0%
Totals Coverage Status
Change from base Build 402: 0.08%
Covered Lines: 1955
Relevant Lines: 2307
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement. version 2 RxGo v2.
Projects
None yet
Milestone
version 2
Development

Successfully merging this pull request may close these issues.
2 participants
@teivah @coveralls