Skip to content

Tests refactoring #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 8, 2019
Merged

Tests refactoring #205

merged 6 commits into from
Jun 8, 2019

Conversation

teivah
Copy link
Member

@teivah teivah commented Jun 8, 2019

Tests refactoring to get rid of ginkgo and gomega to focus on internal testing framework.
Time to execute the tests: from 16 seconds to 440 ms.

@teivah teivah mentioned this pull request Jun 8, 2019
Closed
@coveralls
Copy link

coveralls commented Jun 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 420

  • 24 of 58 (41.38%) changed or added relevant lines in 1 file are covered.
  • 51 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.2%) to 81.537%
Changes Missing Coverage Covered Lines Changed/Added Lines %
assert.go 24 58 41.38%
Files with Coverage Reduction New Missed Lines %
connectableobservable.go 2 18.26%
observablecreate.go 49 70.59%
Totals Coverage Status
Change from base Build 407: -3.2%
Covered Lines: 1921
Relevant Lines: 2356
💛 - Coveralls

@teivah teivah merged commit 11a3112 into v2 Jun 8, 2019
@teivah teivah deleted the tests branch June 24, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teivah @coveralls